Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sparksql] Improve complex type result parsing #3422

Merged
merged 5 commits into from
Aug 2, 2023
Merged

[sparksql] Improve complex type result parsing #3422

merged 5 commits into from
Aug 2, 2023

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Aug 1, 2023 •
edited
Loading

What changes were proposed in this pull request?

  • This change fixes the edge cases for complex datatypes which were still failing: arrays, maps and structs.

How was this patch tested?

  • Tested in local Hue by connecting it to Spark3 running in a cluster.
  • Added new unit tests.

@Harshg999 Harshg999 self-assigned this Aug 1, 2023
@Harshg999 Harshg999 enabled auto-merge (squash) August 1, 2023 11:02
JohanAhlen
JohanAhlen approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

How about a unit test?

@Harshg999 Harshg999 disabled auto-merge August 1, 2023 14:34
wing2fly
wing2fly approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@wing2fly wing2fly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to add the comment to explain the detail.

@Harshg999 Harshg999 enabled auto-merge (squash) August 2, 2023 06:48
@Harshg999 Harshg999 merged commit 481b1d3 into master Aug 2, 2023
2 checks passed
@Harshg999 Harshg999 deleted the fix-sparksql-map branch August 2, 2023 07:19
tabraiz12 pushed a commit that referenced this pull request Oct 4, 2023
@Harshg999
[sparksql] Improve complex data type result parsing and add UTs (#3422)
2b45dcc 
(cherry picked from commit 481b1d3)
wing2fly pushed a commit that referenced this pull request Mar 6, 2024
@Harshg999 @wing2fly
CDPD-58012: [sparksql] Improve complex data type result parsing and a…
b673366 
…dd UTs (#3422)

(cherry picked from commit 481b1d3)
(cherry picked from commit 2b45dcc)
(cherry picked from commit 60f0b8b)
Change-Id: I0f683b78e6c12131b005dae20cd913cac05b74b4
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
@Harshg999
CDPD-58012: [sparksql] Improve complex data type result parsing and a…
60f0b8b 
…dd UTs (#3422)

(cherry picked from commit 481b1d3)
(cherry picked from commit 2b45dcc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing2fly wing2fly wing2fly approved these changes

@amitsrivastava amitsrivastava amitsrivastava approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@quadoss quadoss quadoss approved these changes

@bjornalm bjornalm Awaiting requested review from bjornalm

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Harshg999 @wing2fly @amitsrivastava @JohanAhlen @quadoss