Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom jceks #3508

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Support custom jceks #3508

merged 1 commit into from
Oct 23, 2023

Conversation

sreenaths
Copy link
Collaborator

What changes were proposed in this pull request?

  • Support custom jceks file path.
  • Right now its hard coded to /jceks/secrets.jceks

How was this patch tested?

  • Manually tested in a real cluster

JohanAhlen
JohanAhlen approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

athithyaaselvam
athithyaaselvam approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@athithyaaselvam athithyaaselvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sreenaths sreenaths merged commit f051be8 into cloudera:master Oct 23, 2023
4 checks passed
@sreenaths sreenaths deleted the custom-jceks branch October 23, 2023 20:20
@sreenaths
Copy link
Collaborator Author

Thank you @JohanAhlen and @athithyaaselvam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athithyaaselvam athithyaaselvam athithyaaselvam approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@ranade1 ranade1 Awaiting requested review from ranade1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreenaths @JohanAhlen @athithyaaselvam