Project start #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
Signed-off-by: Fabio José <fabiojose@gmail.com>
|
Close to fix the signoff |
lance
added a commit
that referenced
this pull request
Jun 29, 2020
This is a major rewrite of the entire codebase into TypeScript. Nearly all tests have been retained except where behavior is significantly different. Some highlights of these changes: * lowercase all CloudEvent properties and fix base64 encoded data Previously there was a format() function that would convert a CloudEvent object into JSON with all of the properties lowercased. With this rewrite a CloudEvent object can be converted to JSON simply with JSON.stringify(). However, in order to be compliant with the JSON representation outlined in the spec here https://github.com/cloudevents/spec/blob/v1.0/json-format.md all of the event properties must be all lowercase. * lib(transport): make transport mode an Enum * src: allow custom headers (#1) * lib(exports): export explicitly versioned names where appropriate * lib(cloudevent): modify ctor to accept extensions inline * lib(cloudevent): make extensions a part of the event object * test: convert all tests to typescript * examples: update all examples with latest API changes * docs: update README with latest API changes * src: add prettier for code style and fix a lot of linting errors * lib: move data decoding to occur within the CloudEvent object Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look in this project start for the sdk-javascript.