Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot clone this repository on Windows #26

Closed
lowenna opened this issue Nov 6, 2016 · 12 comments
Closed

Cannot clone this repository on Windows #26

lowenna opened this issue Nov 6, 2016 · 12 comments

Comments

@lowenna
Copy link

lowenna commented Nov 6, 2016

There is at least one file in this repo which has a colon its filename which means as part of revendoring the docker engine http://GitHub.com/docker/docker (which incorporates part of this repo in its vendor structure), the revendoring process using the vndr tool (https://github.com/LK4D4/vndr) by @LK4D4 fails on Windows (colon is not a valid character in a filename).

Unfortunately git clone attempts to clone the entire repo, and I can't just add the directory to the .gitignore.

Would it be possible to rename this file? (Or others which similarly have invalid Windows characters in their filenames?)

2016/11/06 13:31:49 Errors on clone:
github.com/cloudflare/cfssl: Err: exit status 128, out: Cloning into 'E:\go\src\github.com\docker\docker\vendor\github.com\cloudflare\cfssl'...
error: unable to create file vendor/github.com/cloudflare/cfssl_trust/ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-11-26_SHA1WithRSA.crt: Invalid argument
error: unable to create file vendor/github.com/cloudflare/cfssl_trust/ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-11-26_SHA1WithRSA_2.crt: Invalid argument
@mitchcapper
Copy link
Contributor

@jhowardmsft
See ticket #23 I already fixed the naming bug but they need to re-generate the stored certs.

@lowenna
Copy link
Author

lowenna commented Dec 5, 2016

Thanks @mitchcapper. Is there a repo or issue somewhere elsewhere I can ping to get the certs regenerated?

@mitchcapper
Copy link
Contributor

@jhowardmsft
Technically we could submit a PR with the actual re-generated certificates but I assumed one of the project managers would instead prefer to do so. cloudflare/cfssl#589 also covers it.

@kisom
Copy link
Contributor

kisom commented Dec 5, 2016

@mitchcapper @jhowardmsft We've been pretty busy lately, but I'll have this done by the end of the week.

@lowenna
Copy link
Author

lowenna commented Dec 5, 2016

@kisom Thank you! 😄

@lowenna
Copy link
Author

lowenna commented Jan 30, 2017

@kisom - Any chance you would be able to do this soon? Thanks!

@kisom
Copy link
Contributor

kisom commented Jan 30, 2017

@jhowardmsft We did a new release recently --- it should be updated. If you could test on Windows and let us know if it works, that would be helpful (we'd be comfortable tagging a new release then).

@lowenna
Copy link
Author

lowenna commented Jan 30, 2017

@Kison - unfortunately, it is still broken on Windows - attempting to clone both cloudflare/cfssl and cloudflare/cfssl_trust:

E:\go\src\github.com> git clone https://github.com/cloudflare/cfssl e:\go\src\github.com\cloudflare\cfssl
Cloning into 'e:\go\src\github.com\cloudflare\cfssl'...
remote: Counting objects: 7664, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 7664 (delta 0), reused 0 (delta 0), pack-reused 7660
Receiving objects: 100% (7664/7664), 8.54 MiB | 2.61 MiB/s, done.
Resolving deltas: 100% (3368/3368), done.
Checking connectivity... done.
error: unable to create file vendor/github.com/cloudflare/cfssl_trust/ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-
11-26_SHA1WithRSA.crt (Invalid argument)
error: unable to create file vendor/github.com/cloudflare/cfssl_trust/ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-
11-26_SHA1WithRSA_2.crt (Invalid argument)
Checking out files: 100% (3236/3236), done.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

E:\go\src\github.com>
E:\go\src\github.com> git clone https://github.com/cloudflare/cfssl_trust e:\go\src\github.com\cloudflare\cfssl_trust
Cloning into 'e:\go\src\github.com\cloudflare\cfssl_trust'...
remote: Counting objects: 1004, done.
Receiving oemote: Total 1004 (delta 0), reused 0 (delta 0), pack-reused 1004
 MiB/s
Receiving objects: 100% (1004/1004), 3.41 MiB | 1.87 MiB/s, done.
Resolving deltas: 100% (101/101), done.
Checking connectivity... done.
error: unable to create file ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-11-26_SHA1WithRSA.crt (Invalid argument)
error: unable to create file ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-11-26_SHA1WithRSA_2.crt (Invalid argument
)
error: unable to create file intermediate_ca/*000webhostcom_6a63c6175a0b3068555e5a7be4c3e21ed3e058d3_3a0bf25584b6740631b
24ecb16efe5fd.crt (Invalid argument)
error: unable to create file intermediate_ca/*24fxcom_91f7df18d58f83434e18ddefeac0b701f897c898_8a0d00d8363d9c9e.crt (Inv
alid argument)
error: unable to create file intermediate_ca/*24hae_b7dd725c05c691835c0b98f21b40e202fb0eb518_debdeda5db192c69.crt (Inval
id argument)
error: unable to create file intermediate_ca/*adcocktailcom__61947eba44931387ca8190e122da37f0.crt (Invalid argument)
error: unable to create file intermediate_ca/*aftonchemicalcom_72fdac302e7fb0b7df8aa22ab780f6599bd5cbe9_7568f8397682131c
.crt (Invalid argument)
error: unable to create file intermediate_ca/*aleaenginecom_2c566acf6f7ed543fc3cde72f86cc9fd9d9c0fe8_1784e51849349373a6d
1d301ae4cfc82.crt (Invalid argument)
error: unable to create file intermediate_ca/*americanapparelcomau__771752c8c95ea02ad84ed273af4291c9.crt (Invalid argume
nt)
error: unable to create file intermediate_ca/*assemblacom_5fee241b24f0205811654e3979ca3c2216ac0c66_51596375119402ac.crt
(Invalid argument)
error: unable to create file intermediate_ca/*austriancom_46616ea9a2c1c630824476618e24bafe7644cac0_39caff7a6cda600a7e2a2
9f6.crt (Invalid argument)
error: unable to create file intermediate_ca/*bestcompanycom_20145f4da1d1e73712c5840feb4db66b65762bd4_7393a8e0c5db62b79a
2e8f08f110bd55.crt (Invalid argument)
error: unable to create file intermediate_ca/*bestdebtcompanyscom_b994f935d284e2d760bf1efb353d729091f12f5e_dd8a8c7e72905
84375405bb90e2f421a.crt (Invalid argument)
error: unable to create file intermediate_ca/*bestdebtcompanyscom_ed6b45ed32ea3ea2a6e8d328220d8cb5c7353f15_79aaf215fd5b7
d66f313d37a8084c4d2.crt (Invalid argument)
error: unable to create file intermediate_ca/*biblecom_284d12fa4584d7b61499df607c1522cefb69e0de_1121b9a4536ea55ec2bb8a4c
93f82e6d8130.crt (Invalid argument)
error: unable to create file intermediate_ca/*binbahis2com_6f640b607c82c13cb1c948c3ed4bd1b711f90b3b_42b13eba529253b29df6
82759c9af5ef.crt (Invalid argument)
error: unable to create file intermediate_ca/*bitcoincom_94aed6bd384d870fd1e55c742200c4cbf8fe1769_9d96f35732d467f7d5ad42
e89f0f86dc.crt (Invalid argument)
error: unable to create file intermediate_ca/*bitcoinmagazinecom_7a6981fddb87ce56832595c4bcb5971eaa2a5e3a_423c8a581b5bb4
13.crt (Invalid argument)
error: unable to create file intermediate_ca/*bkdeliverscomsg_756cab703c72ee72c418cf242d38fe4278bf7949_811bba20439f73b11
2a70401bd25a07c.crt (Invalid argument)
error: unable to create file intermediate_ca/*blommingcom_cc68228ffae14a3ea8f4ddcd86f69913b9f1ee1d_17ffcad3b07f93bf.crt
(Invalid argument)
error: unable to create file intermediate_ca/*bonjourhkcom_6436acca66bac29327163644525d6b63e232bde7_2779a03aa2c1d3.crt (
Invalid argument)
error: unable to create file intermediate_ca/*budgetvmcom__6341e4a94c89ec15465083cafdd2d409.crt (Invalid argument)
error: unable to create file intermediate_ca/*carbonadsnet_d7426c4b31bf84f08294e11dbe73623ae698da8f_4be9b96668161f3f75d4
52b5e02aee11.crt (Invalid argument)
error: unable to create file intermediate_ca/*centronet_3b4e255de39b1d2b80ed8601a02842387eb51436_0faf0a1d5a04069f2ca4d72
76b6c2764.crt (Invalid argument)
error: unable to create file intermediate_ca/*cliqueshopcom_2a336d862487b59cce0ecc4b47dd8df927ff4af5_f56140360368bf75492
9c591b0880d6f.crt (Invalid argument)
error: unable to create file intermediate_ca/*crazydomainscouk_6fead90ec84ecc363167019eab86da5503c2e47b_e639990801c0c8c6
baa87104f8250e86.crt (Invalid argument)
error: unable to create file intermediate_ca/*discordco_a66b67cf4c7447382a87baa065359bf33e80b9ae_48c328842e6cd9bbe33d9c0
0fba07b8b.crt (Invalid argument)
error: unable to create file intermediate_ca/*drivenowcomau__39820147fb6ad523e801b4ffe5d08160.crt (Invalid argument)
error: unable to create file intermediate_ca/*dxcom_9180b4a81620b0e0ba2ca3f8580bbc21e89a9914_cc25d3eed440bcda.crt (Inval
id argument)
error: unable to create file intermediate_ca/*embedlycom_e58b5bbde7f62d1fd24a117581874d12677408ba_1ff221c6c5c9eae45fbd7a
455eea2d4e.crt (Invalid argument)
error: unable to create file intermediate_ca/*eventercoil__4bae9cf2232029fd9c2bfc4b92d1adbc.crt (Invalid argument)
error: unable to create file intermediate_ca/*flightradar24com_6d3c2699ea2afd678148d11328f5780ecbe73ed7_5d8856a943f3b4a6
.crt (Invalid argument)
error: unable to create file intermediate_ca/*ghostruckcom_a7a10bff352516f681f24fd1aa564478d035fdbe_17d9f2212e3f7bcd.crt
 (Invalid argument)
error: unable to create file intermediate_ca/*grandoptioncom_ad0852eeaedd1ad661326fa9be6675fcd6d47334_6859438bed94ba89.c
rt (Invalid argument)
error: unable to create file intermediate_ca/*imgsociapluscom_a060350b235654c612058ed2491237bbce400d21_3da30ea553c101a12
beb3eadae00ded7.crt (Invalid argument)
error: unable to create file intermediate_ca/*meritnationcom_70ebb0019da5c5ae91610b61753db129adda4589_22bfddbaddec9564.c
rt (Invalid argument)
error: unable to create file intermediate_ca/*n2uitivecom__4a3c9594522c2dcca794958bd5419f4a.crt (Invalid argument)
error: unable to create file intermediate_ca/*ncpluspl_63fd2b8036956b6921f9de276aee01f361398bb7_1e9848d8b57e4f498dd806a1
9870130e.crt (Invalid argument)
error: unable to create file intermediate_ca/*nyxopnet__666d4057f48bebb48b1962213817ed13.crt (Invalid argument)
error: unable to create file intermediate_ca/*oddconceptskr_230fd338ad09a5c651ce32a61740e47950aef039_490d082f7c6c01d2f9d
5df5f1c9734e4.crt (Invalid argument)
error: unable to create file intermediate_ca/*ondemandkoreacom_066096a2eb9885a4a0bda59f095b7b57376f7f58_324bc7241fa40f0f
72fb928c3386f7db.crt (Invalid argument)
error: unable to create file intermediate_ca/*qalizecom_9b8ca06371ac80380a8258324e14f890cbf8758a_61ec19076bb9f7e0.crt (I
nvalid argument)
error: unable to create file intermediate_ca/*realmio_b8db1c15d691d09c6d071ef6a6722776f31e3210_85591cadc75ce6c519a693294
452c5a7.crt (Invalid argument)
error: unable to create file intermediate_ca/*sandiegogov_367ab2e881c23d9cec1c13bc2fa2f46646ece266_a1193b2484c28fdd.crt
(Invalid argument)
error: unable to create file intermediate_ca/*sandiegogov_bbc5cdedc625c54782bcbfea50f817e823da1b94_0c38ed541b455427.crt
(Invalid argument)
error: unable to create file intermediate_ca/*senioradvisorcom_9625f29aa37407a44efec07893aeaf5c62a69fcd_1121d1290fff7ff7
78ead739d884d1086fef.crt (Invalid argument)
error: unable to create file intermediate_ca/*simplexsolutionsinccom_4441673cf6bd4cce0c2fe4e37bc138b4babf4bda_bd0749abe9
cb4d738e5cce07925c1d5e.crt (Invalid argument)
error: unable to create file intermediate_ca/*smrtappcom_755862a786129e8d2dad1b670fe1b3788fda8c31_a0c14a924623f373664dfe
358fcacfb7.crt (Invalid argument)
error: unable to create file intermediate_ca/*solitairearenacom_dd5b3fd5c41e8fc2fec8f8049b66f87cb98ba526_822389d2dcfe5ec
5.crt (Invalid argument)
error: unable to create file intermediate_ca/*thetileappcom_40500faa4e2fbb39c88c6ebf372ddfd6cc8a015a_4f27c38beefacd59.cr
t (Invalid argument)
error: unable to create file intermediate_ca/*thisdatacom_e856e813f91a29b1007a07e7d0cbdf282ab7e93f_543840e8f9913ab4ca356
32ed7ba0ccc.crt (Invalid argument)
error: unable to create file intermediate_ca/*tvppl_4c4089dd479fe0a1d8ca954ef6988d864528dfa7_6cd9e358134da3cf08d0aa409e9
d75c7.crt (Invalid argument)
error: unable to create file intermediate_ca/*wegolookcom_a160b10f610cb415d62357b7e65d5891604b5dff_c58db0bf7480f718.crt
(Invalid argument)
error: unable to create file intermediate_ca/*worldwidebookiescom_a52ba15beb10f83e2bf58297e5f1c3342d917eb4_4a77df91717b4
68dfdec7539636ca637.crt (Invalid argument)
error: unable to create file intermediate_ca/*zitrogamescom_634a8fc917537509ffcbe8c37bc2e251257a1427_f72118cdb79b9f98e00
16d68a82306ec.crt (Invalid argument)
Checking out files: 100% (2311/2311), done.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

E:\go\src\github.com>

@mitchcapper
Copy link
Contributor

No not fixed on master.

C:\temp> git clone https://github.com/cloudflare/cfssl_trust.git
Cloning into 'cfssl_trust'...
remote: Counting objects: 1004, done.
remote: Total 1004 (delta 0), reused 0 (delta 0), pack-reused 1004
Receiving objects: 100% (1004/1004), 3.41 MiB | 355.00 KiB/s, done.

Resolving deltas: 100% (101/101), done.
error: unable to create file ca-bundle/SwissSignCA(RSAIKMay6199918:00:58)_2000-11-26_SHA1WithRSA.crt: Invalid argument

Did they get renamed per the patch?

@lowenna
Copy link
Author

lowenna commented Feb 16, 2017

What I can I do to help progress this? Unfortunately it's blocking me on Windows re-vendoring docker.

@kisom
Copy link
Contributor

kisom commented Apr 24, 2017

The repo should be cloneable on Windows now.

@kisom kisom closed this as completed Apr 24, 2017
@lowenna
Copy link
Author

lowenna commented Apr 24, 2017

@kisom Nice, yes, it is. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants