Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add TurboShake{128,256} #430

Merged
merged 1 commit into from
May 3, 2023
Merged

internal: add TurboShake{128,256} #430

merged 1 commit into from
May 3, 2023

Conversation

bwesterb
Copy link
Member

@bwesterb bwesterb commented Apr 18, 2023

goos: darwin
goarch: arm64
pkg: github.com/cloudflare/circl/internal/sha3
BenchmarkPermutationFunctionTurbo-12    	 7648284	       145.6 ns/op	1374.07 MB/s
BenchmarkPermutationFunction-12         	 4152145	       289.1 ns/op	 691.77 MB/s
BenchmarkSha3_512_MTU-12                	  200443	      5956 ns/op	 226.66 MB/s
BenchmarkSha3_384_MTU-12                	  277851	      4302 ns/op	 313.79 MB/s
BenchmarkSha3_256_MTU-12                	  347239	      3416 ns/op	 395.19 MB/s
BenchmarkSha3_224_MTU-12                	  370054	      3258 ns/op	 414.40 MB/s
BenchmarkShake128_MTU-12                	  420195	      2842 ns/op	 475.10 MB/s
BenchmarkShake256_MTU-12                	  390090	      3069 ns/op	 439.88 MB/s
BenchmarkShake256_16x-12                	   29004	     41288 ns/op	 396.82 MB/s
BenchmarkShake256_1MiB-12               	     506	   2360097 ns/op	 444.29 MB/s
BenchmarkTurboShake128_1MiB-12          	    1160	   1026859 ns/op	1021.15 MB/s
BenchmarkTurboShake256_1MiB-12          	     951	   1253763 ns/op	 836.34 MB/s
BenchmarkSha3_512_1MiB-12               	     274	   4353505 ns/op	 240.86 MB/s
PASS
ok  	github.com/cloudflare/circl/internal/sha3	17.678s

@bwesterb bwesterb requested a review from armfazh April 18, 2023 12:15
@bwesterb bwesterb changed the title intenral: add TurboShake{128,256} internal: add TurboShake{128,256} Apr 18, 2023
simd/keccakf1600/f1600x.go Outdated Show resolved Hide resolved
simd/keccakf1600/f1600x.go Show resolved Hide resolved
@bwesterb bwesterb force-pushed the bas/turboshake branch 2 times, most recently from a561854 to a3f1816 Compare April 19, 2023 11:09
@bwesterb
Copy link
Member Author

bwesterb commented May 1, 2023

@armfazh I addressed the comments. Please have another look.

Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just fix the nits.

internal/sha3/sha3_test.go Outdated Show resolved Hide resolved
internal/sha3/shake.go Outdated Show resolved Hide resolved
internal/sha3/shake.go Outdated Show resolved Hide resolved
simd/keccakf1600/f1600x2_arm64.s Outdated Show resolved Hide resolved
simd/keccakf1600/internal/asm/go.sum Outdated Show resolved Hide resolved
@armfazh armfazh requested a review from cjpatton May 1, 2023 21:45
@armfazh armfazh added the new feature New functionality or module label May 1, 2023
@bwesterb
Copy link
Member Author

bwesterb commented May 2, 2023

lgtm, just fix the nits.

Thanks. I addressed the comments.

@armfazh armfazh merged commit 90d7565 into main May 3, 2023
@armfazh armfazh deleted the bas/turboshake branch May 3, 2023 20:46
jooola referenced this pull request in hetznercloud/terraform-provider-hcloud Jan 9, 2024
…834)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/cloudflare/circl](https://togithub.com/cloudflare/circl) |
`v1.3.3` -> `v1.3.7` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcloudflare%2fcircl/v1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcloudflare%2fcircl/v1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcloudflare%2fcircl/v1.3.3/v1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcloudflare%2fcircl/v1.3.3/v1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

### GitHub Vulnerability Alerts

####
[GHSA-9763-4f94-gfch](https://togithub.com/cloudflare/circl/security/advisories/GHSA-9763-4f94-gfch)

### Impact
On some platforms, when an attacker can time decapsulation of Kyber on
forged cipher texts, they could possibly learn (parts of) the secret
key.

Does not apply to ephemeral usage, such as when used in the regular way
in TLS.

### Patches
Patched in 1.3.7.

### References
- [kyberslash.cr.yp.to](https://kyberslash.cr.yp.to/)

---

### Release Notes

<details>
<summary>cloudflare/circl (github.com/cloudflare/circl)</summary>

###
[`v1.3.7`](https://togithub.com/cloudflare/circl/releases/tag/v1.3.7):
CIRCL v1.3.7

[Compare
Source](https://togithub.com/cloudflare/circl/compare/v1.3.6...v1.3.7)

#### CIRCL v1.3.7

##### What's Changed

- build(deps): bump golang.org/x/crypto from
0.3.1-0.20221117191849-2c476679df9a to 0.17.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/cloudflare/circl/pull/467](https://togithub.com/cloudflare/circl/pull/467)
- kyber: remove division by q in ciphertext compression by
[@&#8203;bwesterb](https://togithub.com/bwesterb) in
[https://github.com/cloudflare/circl/pull/468](https://togithub.com/cloudflare/circl/pull/468)
- Releasing CIRCL v1.3.7 by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/469](https://togithub.com/cloudflare/circl/pull/469)

##### New Contributors

- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[https://github.com/cloudflare/circl/pull/467](https://togithub.com/cloudflare/circl/pull/467)

**Full Changelog**:
cloudflare/circl@v1.3.6...v1.3.7

###
[`v1.3.6`](https://togithub.com/cloudflare/circl/releases/tag/v1.3.6):
CIRCL v1.3.6

[Compare
Source](https://togithub.com/cloudflare/circl/compare/v1.3.5...v1.3.6)

#### CIRCL v1.3.6

##### What's Changed

- internal: add TurboShake{128,256} by
[@&#8203;bwesterb](https://togithub.com/bwesterb) in
[https://github.com/cloudflare/circl/pull/430](https://togithub.com/cloudflare/circl/pull/430)
- Kangaroo12 draft -10 by
[@&#8203;bwesterb](https://togithub.com/bwesterb) in
[https://github.com/cloudflare/circl/pull/431](https://togithub.com/cloudflare/circl/pull/431)
- Add K12 as XOF by [@&#8203;bwesterb](https://togithub.com/bwesterb) in
[https://github.com/cloudflare/circl/pull/437](https://togithub.com/cloudflare/circl/pull/437)
- xof/k12: Fix a typo in the package documentation by
[@&#8203;cjpatton](https://togithub.com/cjpatton) in
[https://github.com/cloudflare/circl/pull/438](https://togithub.com/cloudflare/circl/pull/438)
- Set CIRCL version for generated assembler code. by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/440](https://togithub.com/cloudflare/circl/pull/440)
- Add tkn20 benchmarks by
[@&#8203;tanyav2](https://togithub.com/tanyav2) in
[https://github.com/cloudflare/circl/pull/442](https://togithub.com/cloudflare/circl/pull/442)
- Add partially blind RSA implementation by
[@&#8203;chris-wood](https://togithub.com/chris-wood) in
[https://github.com/cloudflare/circl/pull/445](https://togithub.com/cloudflare/circl/pull/445)
- Update doc.go by
[@&#8203;nadimkobeissi](https://togithub.com/nadimkobeissi) in
[https://github.com/cloudflare/circl/pull/447](https://togithub.com/cloudflare/circl/pull/447)
- tss/rsa: key generation for threshold RSA (safe primes) by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/450](https://togithub.com/cloudflare/circl/pull/450)
- Bumping Go version for CI jobs. by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/457](https://togithub.com/cloudflare/circl/pull/457)
- Spelling by [@&#8203;jsoref](https://togithub.com/jsoref) in
[https://github.com/cloudflare/circl/pull/456](https://togithub.com/cloudflare/circl/pull/456)
- blindrsa: updating blindrsa to be compliant with RFC9474 by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/464](https://togithub.com/cloudflare/circl/pull/464)
- Releasing CIRCL v1.3.6 by
[@&#8203;armfazh](https://togithub.com/armfazh) in
[https://github.com/cloudflare/circl/pull/465](https://togithub.com/cloudflare/circl/pull/465)

##### New Contributors

- [@&#8203;nadimkobeissi](https://togithub.com/nadimkobeissi) made their
first contribution in
[https://github.com/cloudflare/circl/pull/447](https://togithub.com/cloudflare/circl/pull/447)
- [@&#8203;jsoref](https://togithub.com/jsoref) made their first
contribution in
[https://github.com/cloudflare/circl/pull/456](https://togithub.com/cloudflare/circl/pull/456)

**Full Changelog**:
cloudflare/circl@v1.3.3...v1.3.6

###
[`v1.3.5`](https://togithub.com/cloudflare/circl/compare/v1.3.4...v1.3.5)

[Compare
Source](https://togithub.com/cloudflare/circl/compare/v1.3.4...v1.3.5)

###
[`v1.3.4`](https://togithub.com/cloudflare/circl/compare/v1.3.3...v1.3.4)

[Compare
Source](https://togithub.com/cloudflare/circl/compare/v1.3.3...v1.3.4)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/hetznercloud/terraform-provider-hcloud).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New functionality or module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants