Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct memory leaks #9

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Correct memory leaks #9

merged 2 commits into from
Sep 5, 2018

Conversation

MikeEdgar
Copy link

Please consider this pull request to free memory currently left allocated. Memory leaks may occur over time in the do_accept and new_connection functions.

The scenario tested to produce the problem is using mmproxy in front of OpenSSH. Without the changes, this script loop will cause growing heap utilization due to the leak.

for i in {1..10000}; do 
  echo -en "PROXY TCP4 0.0.0.0 0.0.0.0 0 0\r\nSSH-2.0-" | nc -W1 localhost 2222 > /dev/null; 
done

@majek majek merged commit fd165af into cloudflare:master Sep 5, 2018
@majek
Copy link
Contributor

majek commented Sep 5, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants