add stub implementation for node:dns #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Nov 25, 2024
| strictEqual(typeof dns.reverse, 'function'); | ||
| strictEqual(typeof dns.setDefaultResultOrder, 'function'); | ||
| strictEqual(typeof dns.getDefaultResultOrder, 'function'); | ||
| strictEqual(typeof dns.setServers, 'function'); |
There was a problem hiding this comment.
A pattern like the following that also checks that the stub throws would likely be a bit easier, but non-blocking.
['lookup', 'lookupService', 'resolve', ...].forEach((i) => {
strictEqual(typeof dns[i], 'function);
throws(() => dns[i](...), { ... })
});
jasnell
approved these changes
Nov 25, 2024
jasnell
reviewed
Nov 25, 2024
Co-authored-by: James M Snell <jsnell@cloudflare.com>
anonrig
force-pushed
the
yagiz/add-stub-node-dns-impl
branch
from
86d3d3c to
7b2290f
Compare
danlapid
pushed a commit
that referenced
this pull request
Dec 3, 2024
* add stub implementation for node:dns * Update src/workerd/api/node/dns.h Co-authored-by: James M Snell <jsnell@cloudflare.com> * simplify tests --------- Co-authored-by: James M Snell <jsnell@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a stub implementation for
node:dns. Remember that there is stillnode:dns/promisesthat needs to be stubbed.Small note: I'm in the process of investigating fully implementing node:dns in the short term.