Implement a testMode for running wrangler's dev function via API #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1cf7983 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2980556025/npm-package-wrangler-1538You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1538/npm-package-wrangler-1538Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2980556025/npm-package-wrangler-1538 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
- Coverage 80.18% 74.13% -6.06%
==========================================
Files 92 97 +5
Lines 6224 7070 +846
Branches 1603 1850 +247
==========================================
+ Hits 4991 5241 +250
- Misses 1233 1829 +596
|
rozenmd
force-pushed
the
react-free-dev-api
branch
2 times, most recently
from
6c0b6d5 to
63b3781
Compare
rozenmd
changed the title
rozenmd
changed the title
rozenmd
requested review from
threepointone,
petebacondarwin and
a team
as code owners
rozenmd
force-pushed
the
react-free-dev-api
branch
from
16df463 to
d604c48
Compare
rozenmd
force-pushed
the
react-free-dev-api
branch
from
92a9f9e to
28e2c4b
Compare
rozenmd
changed the title
rozenmd
force-pushed
the
react-free-dev-api
branch
from
43267e1 to
d5eb1bb
Compare
This was referenced Aug 30, 2022
Closed
rozenmd
force-pushed
the
react-free-dev-api
branch
from
d5eb1bb to
cca6063
Compare
rozenmd
commented
Aug 31, 2022
threepointone
approved these changes
Sep 1, 2022
| logPrefix, | ||
| enablePagesAssetsServiceBinding, | ||
| }: LocalProps) { | ||
| let local: ChildProcess | undefined; |
There was a problem hiding this comment.
this implementation should be shared with the react version as well, it's just so much code
| @@ -0,0 +1,18 @@ | |||
| import { unstable_dev } from "../api"; | |||
|
|
|||
| jest.unmock("undici"); | |||
There was a problem hiding this comment.
Suggested change
| jest.unmock("undici"); | |
| jest["unmock"]("undici"); |
. update imports fix-up this fixture make TS happy an idea make tests pass? fix Pages extract common logic make pages work? fix? remove ability to rebuild in tests remove watching from no-react extract common warnings split up logic common to both startDev and startApiDev remove watchMode from API's esbuild
rozenmd
force-pushed
the
react-free-dev-api
branch
from
7cf58cf to
e3157d8
Compare
petebacondarwin
approved these changes
Sep 2, 2022
| @@ -1,15 +1,19 @@ | |||
| import { spawnWranglerDev } from "./helpers"; | |||
| console.log(spawnWranglerDev); | |||
There was a problem hiding this comment.
Do we want to land this file in this TODO state?
There was a problem hiding this comment.
Nah i've removed this test and added a follow-up to reimplement it with unstable_dev: #1756
Comment on lines
+4
to
+7
| let worker: { | ||
| fetch: (init?: RequestInit) => Promise<Response | undefined>; | ||
| stop: () => Promise<void>; | ||
| }; |
There was a problem hiding this comment.
We should export a named type for this rather than requiring users to write out the type by hand.
There was a problem hiding this comment.
We do export:
/**
* unstable_dev starts a wrangler dev server, and returns a promise that resolves with utility functions to interact with it.
* @param {string} script
* @param {DevOptions} options
*/
export declare function unstable_dev(script: string, options?: DevOptions, apiOptions?: DevApiOptions): Promise<{
stop: () => Promise<void>;
fetch: (init?: RequestInit | undefined) => Promise<Response | undefined>;
waitUntilExit: () => Promise<void>;
}>;I just couldn't figure out how to make the types work within the mono repo 😕
rozenmd
force-pushed
the
react-free-dev-api
branch
from
eabec89 to
bbef05b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
wrangler.unstable_dev()would only support running one instance of wrangler at a time, as Ink only lets you render one instance of React. This resulted in test failures in CI.This change creates pure JS/TS versions of these React hooks:
As a side-effect of removing React, tests should run faster in CI.
What we're not supporting (in this PR, anyway):
Follow-up task:
Closes #1432
Closes #1419