-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update unenv dependency version #6920
Conversation
🦋 Changeset detectedLatest commit: 35d3113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/cc @anonrig |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-wrangler-6920 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6920/npm-package-wrangler-6920 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-wrangler-6920 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-create-cloudflare-6920 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-cloudflare-kv-asset-handler-6920 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-miniflare-6920 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-cloudflare-pages-shared-6920 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-cloudflare-vitest-pool-workers-6920 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-cloudflare-workers-editor-shared-6920 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11255696733/npm-package-cloudflare-workers-shared-6920 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
The error in the nodejs-hybrid-app is:
Building the worker to
So it appears that Elsewhere in the code we can see:
The fake From the docs So this polyfill is a bit broken for Cloudflare. I wonder if we need to be more fine grained about polyfilling that global? |
Great analysis @petebacondarwin
unenv should inject the polyfill in the globalScope here. But it looks like this is not working. Also unjs/unenv#318 |
Thanks Pete! |
What this PR solves / how to test
Update unenv - Pulled fixes are listed in the changeset
See unjs/unenv#314
Fixes #6684
Author has addressed the following