Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): disable hybrid perf_hooks #319

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(cloudflare): disable hybrid perf_hooks #319

merged 1 commit into from
Oct 9, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 9, 2024

…oks` (#257)"

It's causing trouble in wrangler, see cloudflare/workers-sdk#6920 (comment)

@vicb vicb added the cloudflare label Oct 9, 2024
@vicb vicb requested review from a team and pi0 as code owners October 9, 2024 12:22
@vicb vicb changed the title Revert "feat(node, cloudflare): fill in api surface for `node:perf_ho… fix: remove perf_hooks from hybrid cloudflare modules Oct 9, 2024
@vicb vicb requested a review from pi0 October 9, 2024 12:51
@pi0 pi0 changed the title fix: remove perf_hooks from hybrid cloudflare modules fix(cloudflare): disable hybrid perf_hooks Oct 9, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pi0 pi0 merged commit e8ea22f into main Oct 9, 2024
2 checks passed
@pi0 pi0 deleted the revert/perf branch October 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants