Do not use env vars for credentials #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note to use user-provided service instances instead. User-provided env vars show up in cf cli (manifest diff) and CC logs. Removed the sentence to use manifest variables to hide security sensitive values. They are printed by cf cli v8 (manifest diff) and the only real use case would be env vars.
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@MerricdeLauney and @sethboyles: FYI as discussed in capi open office hour on 13.4. |
theCKKW
added a commit
that referenced
this pull request
May 13, 2022
theCKKW
added a commit
that referenced
this pull request
May 13, 2022
theCKKW
added a commit
that referenced
this pull request
May 13, 2022
theCKKW
added a commit
that referenced
this pull request
May 13, 2022
theCKKW
added a commit
that referenced
this pull request
May 13, 2022
cf-gitbot
added
in progress
delivered
accepted
and removed
unscheduled
in progress
delivered
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to use user-provided service instances instead.
User-provided env vars show up in cf cli (manifest diff) and CC logs.
Removed the sentence to use manifest variables to hide
security sensitive values. They are printed by cf cli v8 (manifest diff) and
the only real use case would be env vars.