Mark Symfony integration tests as pending #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun024
added a commit
that referenced
this pull request
Apr 3, 2025
- Note: this buildpack does not use the common github-config as the buildpack is packaged with the legacy github.com/cloudfoundry/buildpack-packager - Use github token provided for tests as COMPOSER_GITHUB_OAUTH_TOKEN instead of providing it separately - Removed tests not directly related to buildpack functionality (e.g. testing CF functionality like profile scripts) - There were certain tests that ran app frameworks (like Cakephp) as vendored apps and online apps, but the fixtures were wrong - the "vendored" app did not have a vendor dir and was identical to the onilne app. I haven't put the effort to fix such fixtures and removed them. e.g. https://github.com/cloudfoundry/php-buildpack/tree/63193ece34e473e746742163b4c49786476cf1ca/fixtures/cake_local_deps - Tests on Symfony app framework was marked as pending last year (#1000). The tests do not currently run successfully on CF. So I haven't migrated them to switchblade.
robdimsdale
pushed a commit
that referenced
this pull request
Apr 3, 2025
- Note: this buildpack does not use the common github-config as the buildpack is packaged with the legacy github.com/cloudfoundry/buildpack-packager - Use github token provided for tests as COMPOSER_GITHUB_OAUTH_TOKEN instead of providing it separately - Removed tests not directly related to buildpack functionality (e.g. testing CF functionality like profile scripts) - There were certain tests that ran app frameworks (like Cakephp) as vendored apps and online apps, but the fixtures were wrong - the "vendored" app did not have a vendor dir and was identical to the onilne app. I haven't put the effort to fix such fixtures and removed them. e.g. https://github.com/cloudfoundry/php-buildpack/tree/63193ece34e473e746742163b4c49786476cf1ca/fixtures/cake_local_deps - Tests on Symfony app framework was marked as pending last year (#1000). The tests do not currently run successfully on CF. So I haven't migrated them to switchblade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the failing Symfony tests as pending in order to patch https://nvd.nist.gov/vuln/detail/CVE-2024-24821.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test