Skip to content

Comment component permalinks rely on comment.link, which is not a thing in Timber #1948

@tylersticka

Description

@tylersticka

In our theme, I noticed that comment permalinks didn't actually work. They ended up blank.

I looked in our component template, and I see this Twig logic for outputting the permalink:

<a class="c-comment__meta-link"
  href="{{comment.link}}">
  ...
</a>

This is what our docs say about the comment object:

This information may be passed to the component as a comment object matching the structure of a Timber comment.

Looking at that page, there is no reference to a link property for a comment. So I think this must have been an assumption that turned out not to be true.

We can probably use the same technique we're using to build comment IDs to build a hash URL for the href instead.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions