-
Notifications
You must be signed in to change notification settings - Fork 3
Bio layout object #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bio layout object #1505
Conversation
🦋 Changeset detectedLatest commit: 197b72c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: 197b72c 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61295b8d38ae550007843712 😎 Browse the preview: https://deploy-preview-1505--cloudfour-patterns.netlify.app |
Consider this a rough first draft as I am not sure if I'm way off target or not. Looking forward to the feedback, thank you! 🙂 Assumption: The layout object does not need to be concerned with the styling of the content inside of it. |
This PR is ready for another review, thanks! 😄 |
The latest round of feedback has been addressed! 🎉 |
This looks good! I am noticing a few design differences:
Other than that I think it's looking great so far. :) |
Thanks, @AriannaChau! This is the first layout object I've worked on so I wasn't sure how much a layout object should control the styling of the content within the layout. I was under the assumption the styling of the content within the layout object was not the responsibility of the layout object. Is my assumption incorrect? I was using the Feature Group object as a reference and it seemed to not include any styling of the content (it only seems to be responsible for the overall layout of the content) but my assumption could be wrong! ¯\_(ツ)_/¯ |
OOOOHHHH, okay got it got it got it. Then yeah, this looks great! |
Overview
This PR introduces the Bio layout object.
Screenshots
Testing