Skip to content

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Aug 26, 2021

Overview

This PR introduces the Bio layout object.

Screenshots

Screen Shot 2021-08-27 at 2 14 30 PM

Testing

  1. Review the Bio layout object (for reference, the prototype)

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2021

🦋 Changeset detected

Latest commit: 197b72c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerardo-rodriguez gerardo-rodriguez self-assigned this Aug 26, 2021
@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for cloudfour-patterns ready!

🔨 Explore the source changes: 197b72c

🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61295b8d38ae550007843712

😎 Browse the preview: https://deploy-preview-1505--cloudfour-patterns.netlify.app

@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review August 26, 2021 18:38
@gerardo-rodriguez
Copy link
Member Author

gerardo-rodriguez commented Aug 26, 2021

Consider this a rough first draft as I am not sure if I'm way off target or not. Looking forward to the feedback, thank you! 🙂

Assumption: The layout object does not need to be concerned with the styling of the content inside of it.

@gerardo-rodriguez gerardo-rodriguez requested review from a team August 26, 2021 18:40
@gerardo-rodriguez gerardo-rodriguez changed the title Individual Bio Group layout object Bio layout object Aug 27, 2021
@gerardo-rodriguez
Copy link
Member Author

This PR is ready for another review, thanks! 😄

@gerardo-rodriguez
Copy link
Member Author

The latest round of feedback has been addressed! 🎉

@AriannaChau
Copy link
Contributor

AriannaChau commented Aug 27, 2021

This looks good! I am noticing a few design differences:

  • The website links should be centered underneath the avatar and not include bullet points.
  • The job title should be slightly larger than the body text and in turn would probably benefit from a little bit more whitespace between the job title and name.
  • The avatar currently feels a bit large.

Other than that I think it's looking great so far. :)

Screen Shot 2021-08-27 at 3 47 21 PM

Screen Shot 2021-08-27 at 3 47 34 PM

@gerardo-rodriguez
Copy link
Member Author

gerardo-rodriguez commented Aug 27, 2021

I am noticing a few design differences:

  • The website links should be centered underneath the avatar and not include bullet points.
  • The job title should be slightly larger than the body text and in turn would probably benefit from a little bit more whitespace between the job title and name.
  • The avatar feels really big.

Thanks, @AriannaChau!

This is the first layout object I've worked on so I wasn't sure how much a layout object should control the styling of the content within the layout. I was under the assumption the styling of the content within the layout object was not the responsibility of the layout object.

Is my assumption incorrect? I was using the Feature Group object as a reference and it seemed to not include any styling of the content (it only seems to be responsible for the overall layout of the content) but my assumption could be wrong! ¯\_(ツ)_/¯

@AriannaChau
Copy link
Contributor

This is the first layout object I create so I wasn't sure how much a layout object should control the styling of the content within the layout. I was under the assumption the styling of the content within the layout object was not the responsibility of the layout object.

Is my assumption incorrect? I was using the Feature Group object as a reference and it seemed to not include any styling of the content (it only seems to be responsible for the overall layout of the content) but my assumption could be wrong! ¯_(ツ)_/¯

OOOOHHHH, okay got it got it got it. Then yeah, this looks great!

@tylersticka tylersticka removed their request for review August 30, 2021 16:10
@gerardo-rodriguez gerardo-rodriguez merged commit 567d70b into v-next Aug 30, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the feature/individual-bio-object branch August 30, 2021 17:19
@github-actions github-actions bot mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new layout for individual team page
3 participants