Skip to content

Scale down logo more for small screens #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Scale down logo more for small screens #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7504e48
Scale down logo more for small screens
calebeby Aug 31, 2021
6bbe1ce
Prettier
calebeby Aug 31, 2021
b9190e5
Add changeset
calebeby Aug 31, 2021
53e6d2f
Add explanation comment
calebeby Aug 31, 2021
6918af2
Prettier
calebeby Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ten-parrots-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': minor
---

Adjust sizing of logo in sky nav
14 changes: 13 additions & 1 deletion src/components/sky-nav/sky-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ $_masthead-height-sm: ms.step(7);
* around for visual balance. We could subtract this value from the container
* padding, but it felt easier to understand the scope of the change to me
* from this element. (Though now I'm second-guessing myself...)
* 3. ms.step(9) is used instead of ms.step(8) because ms.step(8) leads to a big jump at the large breakpoint
*/
.c-sky-nav__logo-object {
display: block; /* 1 */
Expand All @@ -182,7 +183,18 @@ $_masthead-height-sm: ms.step(7);
margin: (ms.step(-6) * -1); /* 2 */
transition: opacity transition.$slow ease.$out,
transform transition.$quick ease.$out;
width: ms.step(8);
width: fluid.fluid-calc(
breakpoint.$s,
breakpoint.$l,
ms.step(7),
ms.step(9) /* 3 */
);
@media (min-width: breakpoint.$l) {
width: ms.step(8);
}
@media (max-width: breakpoint.$s) {
width: ms.step(7);
}

/**
* When the containing logo is hovered, scale up this element. Scaling this
Expand Down