Skip to content

Introduce Button 'is-slashed' CSS state class, remove aria-pressed logic #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 2, 2021
Merged

Introduce Button 'is-slashed' CSS state class, remove aria-pressed logic #1519

merged 7 commits into from
Sep 2, 2021

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Sep 2, 2021 •
edited
Loading

Overview

This PR refactors the Button component in response to #1508. Changes include:

  • remove the aria-pressed logic
  • introduce a is-slashed CSS state class

Screenshots

Screen Shot 2021-09-02 at 9 59 04 AM

Testing

  1. Review https://deploy-preview-1519--cloudfour-patterns.netlify.app/?path=/docs/components-button--slashed-icon#icon-with-slash

@gerardo-rodriguez gerardo-rodriguez self-assigned this Sep 2, 2021
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 3d6fbe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 2, 2021 •
edited
Loading

✔️ Deploy Preview for cloudfour-patterns ready!

🔨 Explore the source changes: 3d6fbe3

🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61310294cca88c0007bcc9f7

😎 Browse the preview: https://deploy-preview-1519--cloudfour-patterns.netlify.app

@gerardo-rodriguez gerardo-rodriguez changed the title Feature/refactor button pressed Introduce Button 'slashed' modifier, remove aria-pressed logic Sep 2, 2021
@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review September 2, 2021 16:41
@gerardo-rodriguez gerardo-rodriguez requested review from a team September 2, 2021 16:41
tylersticka
tylersticka reviewed Sep 2, 2021
View reviewed changes
@gerardo-rodriguez gerardo-rodriguez changed the title Introduce Button 'slashed' modifier, remove aria-pressed logic Introduce Button 'is-slashed' CSS state class, remove aria-pressed logic Sep 2, 2021
tylersticka
tylersticka approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Gerardo!

@gerardo-rodriguez gerardo-rodriguez merged commit 2947ed2 into v-next Sep 2, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the feature/refactor-button-pressed branch September 2, 2021 22:21
@github-actions github-actions bot mentioned this pull request Sep 2, 2021
Merged
gerardo-rodriguez added a commit that referenced this pull request Sep 2, 2021
@gerardo-rodriguez
Merge branch 'v-next' of github.com:cloudfour/cloudfour.com-patterns …
961a6d6 
…into feature/button-swap

* 'v-next' of github.com:cloudfour/cloudfour.com-patterns:
  Introduce Button 'is-slashed' CSS state class, remove aria-pressed logic (#1519)
  Scale down logo more for small screens (#1517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersticka tylersticka tylersticka approved these changes

Assignees

@gerardo-rodriguez gerardo-rodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit toggling Button pattern to ensure it aligns with updated accessible notifications subscription pattern
2 participants
@gerardo-rodriguez @tylersticka