-
Notifications
You must be signed in to change notification settings - Fork 3
Responsive fallback #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Responsive fallback #1529
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
537ff0d
Add responsive image svg to stories
AriannaChau c5a2fdd
Remove clouds, change grid layout and storybook layout
AriannaChau e366873
Add changeset
AriannaChau 33f67b6
Change title and file names
AriannaChau 51434b9
Update src/assets/illustrations/responsive-fallback.svg
AriannaChau 1580ae3
Update src/assets/illustrations/responsive-fallback.svg
AriannaChau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@cloudfour/patterns': minor | ||
--- | ||
|
||
Add responsive fallback image |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{% embed '@cloudfour/objects/deck/deck.twig' with { | ||
class: 'o-deck--3-column@l' | ||
} %} | ||
{% block content %} | ||
{% for ratio in ratios %} | ||
<figure> | ||
<img src="{{source}}" alt="" style="aspect-ratio: {{ratio}}; max-height: 15em;"> | ||
<figcaption>{{ratio}}</figcaption> | ||
</figure> | ||
{% endfor %} | ||
{% endblock %} | ||
{% endembed %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question, @AriannaChau! 🙂
In Safari, the aspect ratios all look the same in the documentation page. Does that matter? Is this expected? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AGH! No, thank you for bringing that to my attention!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, is it because
aspect-ratio
isn't supported in Safari?https://caniuse.com/mdn-css_properties_aspect-ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Safari doesn't support
aspect-ratio
(though it does in the Technology Preview so it should be rolling out soon)I think that's fine for our pattern documentation site (though I'd be hesitant to use it on our actual site). I'm curious what others think though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I'm fine leaving it as-is for the documentation site. 😉