Simplify fluid values using clamp #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f849544 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: f849544 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/618af72c2ff17c0008485faa 😎 Browse the preview: https://deploy-preview-1578--cloudfour-patterns.netlify.app |
spaceninja
approved these changes
Nov 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaces our property-specific "fluid" mixins with a more versatile
fluid-clampfunction based on an example by @Paul-Hebert. The output is greatly simplified by replacing media queries with theclampfunction.I marked this as a breaking change since it slightly reduces browser support, it removes mixins that were previous available, and it changes the argument order of the remaining functions (what we had previously wasn't very intuitive). But I'm open to feedback if that feels too aggressive.
Testing
Compare various components, objects and prototypes on the deploy preview and compare to the
v-nextversion for regressions.