-
Notifications
You must be signed in to change notification settings - Fork 3
Speaker pattern #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speaker pattern #1607
Conversation
🦋 Changeset detectedLatest commit: 4a38794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: 4a38794 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61aa5cf0ded7c1000847e9ee 😎 Browse the preview: https://deploy-preview-1607--cloudfour-patterns.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gerardo-rodriguez It seems strange to have a pattern that so closely matches the existing Author component.
Did you consider updating the Author component instead, replacing date
with a more flexible/generic option?
@tylersticka Hmm...good question. They are very similar. I can take a closer look! 🔍 👀 |
@tylersticka This PR is ready for another review, appreciate your feedback, thanks! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing to revise this, @gerardo-rodriguez!
Thanks again, @tylersticka! This PR is ready for another review. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version's awesome, @gerardo-rodriguez! More features but it actually seems simpler to use when you read the docs, which is the ideal. My comments are really just affirming some of your instincts regarding accessibility prefix options.
Overview
This PR refactors the Author component so that it can be used for both article and presentation bylines.
Screenshots
Testing