Fix issues related to columned lists in Safari #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 98dbd9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: 98dbd9a 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61afcf80ff08890007113d54 😎 Browse the preview: https://deploy-preview-1612--cloudfour-patterns.netlify.app |
gerardo-rodriguez
approved these changes
Dec 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes three Safari issues that were visible in different situations in the article topics listing:
u-hidden-visuallyelements within the list would cause Safari to increase the scrollable height of the window. This was resolved by addingposition: relativeto children of the list. (It was not effective to add this to the parent.)break-inside: avoidto children of the list. (page-break-insideand-webkit-column-break-insideare common suggestions, but these are older properties that didn't seem to have any more effect)u-space-block-end-0withu-pad-block-end-0in the relevant templates.Screenshots
Before
Highlighting visually divided items and extra space...
After
Testing
The issue was previously symptomatic in "Objects ▸ Overview ▸ Advanced" and "Prototypes ▸ Article Listing ▸ Example," so those are good stories to verify the fix in.