-
Notifications
You must be signed in to change notification settings - Fork 3
"Get Weekly Digests" pattern #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
6b14852
WIP
gerardo-rodriguez 3cdb7f4
Update button to receive aria_controls value
gerardo-rodriguez 60720f8
More WIP
gerardo-rodriguez f7bf494
Work in some of Tyler's suggestions
gerardo-rodriguez 082b5a5
More changes
gerardo-rodriguez a079740
More progress
gerardo-rodriguez d6f47b4
Pretty solid state
gerardo-rodriguez 4f6147d
Some cleanup
gerardo-rodriguez afd8072
Add button_class support to Buttton Swap
gerardo-rodriguez a98c1c2
Use button_class + cleanup
gerardo-rodriguez b45bf8c
More changes
gerardo-rodriguez 26bdc4b
Refactor names
gerardo-rodriguez ad210d9
WIP, adding tests
gerardo-rodriguez 888cb8a
Use page directly for accessibility tree snapshot
gerardo-rodriguez 7f8d450
Add describe block, rename test using "should"
gerardo-rodriguez 64edec0
Make things better
gerardo-rodriguez 831c201
More work
gerardo-rodriguez 12aa611
More progress
gerardo-rodriguez ccdd478
Simplify template a bit
gerardo-rodriguez 9d7f43a
More updates
gerardo-rodriguez af6a7ce
Progress
gerardo-rodriguez 84850e5
Fine-tune test
gerardo-rodriguez 0da57a0
Fix broken code
gerardo-rodriguez 8fa62b3
Adjust layout
gerardo-rodriguez 752c6fc
Update tests
gerardo-rodriguez 24a9992
Fix tab indentation
gerardo-rodriguez 10fddc3
Delete logs
gerardo-rodriguez bcd22cf
Fix layout
gerardo-rodriguez e4f2f7d
Fix broken UI logic (thank you tests!)
gerardo-rodriguez a2c38e4
Make layout better
gerardo-rodriguez 1ab9aa6
Add missing attributes
gerardo-rodriguez 5b510a6
Remove unused code
gerardo-rodriguez ca4d80a
Update comments
gerardo-rodriguez 80ef17e
Fix typo and update tests
gerardo-rodriguez 4b02c69
Add comment
gerardo-rodriguez 75b4d4b
Slight refactor
gerardo-rodriguez 118f2a6
Add comment
gerardo-rodriguez e0883d4
Add content to Storybook story
gerardo-rodriguez e7c1ba4
Update code examples
gerardo-rodriguez 49054e3
Update CI to use Node 16
gerardo-rodriguez dfcc609
Fix typo
gerardo-rodriguez f2e6cf0
Lint files
gerardo-rodriguez 60e2173
Refactor to remove bg color, rename vars
gerardo-rodriguez 81bab30
Remove bgColor from tests
gerardo-rodriguez 5705d9d
Touch-ups
gerardo-rodriguez ec0ee5a
Add a changeset
gerardo-rodriguez f0ce6ba
Remove more form bg color code
gerardo-rodriguez cbffc8e
Add bg color back, theme-specific
gerardo-rodriguez 8cbf7e7
Choose correct gray
gerardo-rodriguez 802b90a
Edit description
gerardo-rodriguez 42d8778
Add makeTwigInclude source
gerardo-rodriguez 3aa54c2
Remove opacity change, not needed
gerardo-rodriguez 975e09a
Use flexbox instead of grid
gerardo-rodriguez dfb3e6d
Delete unnused code
gerardo-rodriguez bf2ce34
Add more comments
gerardo-rodriguez 189764e
Add extra check
gerardo-rodriguez e083296
Update comment
gerardo-rodriguez 2399838
Update src/components/subscription-choices/subscription-choices.scss
gerardo-rodriguez 1362e84
Use existing theme css prop, don't need these
gerardo-rodriguez d808584
Add CSS class to label
gerardo-rodriguez 9d9b917
Use flex shorthand
gerardo-rodriguez fa3619d
c-subscription-choices -> c-subscribe
gerardo-rodriguez 135a341
Better CSS class names
gerardo-rodriguez 0a4c903
Update src/components/subscription-choices/subscription-choices.test.ts
gerardo-rodriguez 9134022
Use toHaveAttribute assertion
gerardo-rodriguez b51acf6
Merge branch 'feature/disclosure-widget' of github.com:cloudfour/clou…
gerardo-rodriguez c6c548d
Lint
gerardo-rodriguez 5766e69
Address PR feedback
gerardo-rodriguez 8c4de41
Fix typo
gerardo-rodriguez 8273485
Close form on Escape
gerardo-rodriguez 0b39b22
Fix comments
gerardo-rodriguez 32c928d
Fix typo
gerardo-rodriguez afc52b3
Use CSS grid because I couldn't flexbox correctly
gerardo-rodriguez fb5c566
Update src/components/button-swap/button-swap.stories.mdx
gerardo-rodriguez 5c744b3
Update src/components/subscription-choices/subscription-choices.scss
gerardo-rodriguez 2ab7015
Update changeset
gerardo-rodriguez 013e962
subscription-choices -> subscribe
gerardo-rodriguez dd7a6da
Update src/components/subscribe/subscribe.test.ts
gerardo-rodriguez 1a6ca26
More filename updates
gerardo-rodriguez 0d3b273
More title changes
gerardo-rodriguez 2a85120
PR feedback
gerardo-rodriguez 297f704
Use an ArgsTable
gerardo-rodriguez c6276bb
Update comments
gerardo-rodriguez 4295313
Add a class template prop to Input Group
gerardo-rodriguez 6273078
Use Input Group component
gerardo-rodriguez d06656b
Update src/components/subscribe/subscribe.twig
gerardo-rodriguez 7437d2a
Update src/objects/input-group/input-group.twig
gerardo-rodriguez b2401fc
controls-wrapper -> controls
gerardo-rodriguez b2df335
Merge branch 'feature/disclosure-widget' of github.com:cloudfour/clou…
gerardo-rodriguez 14ce64e
Revert controls-wrapper -> controls
gerardo-rodriguez c9e2af3
PR feedback, make action not have default
gerardo-rodriguez 6e7d0dc
Remove controls-wrapper
gerardo-rodriguez 810fdea
Delete default form_action
gerardo-rodriguez 3ec5c81
Update broken test
gerardo-rodriguez 73159e1
Fix syntax error
gerardo-rodriguez c9216fd
Address feedback from Caleb
gerardo-rodriguez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@cloudfour/patterns': minor | ||
--- | ||
|
||
- Add Subscribe component | ||
- Update CI workflow to use Node 16 | ||
- Add a `button_class` template prop to the Button Swap component | ||
- Add a `class` template prop to the Input Group component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% embed '@cloudfour/components/subscribe/subscribe.twig' with { | ||
form_id: 'test' | ||
} only %}{% endembed %} | ||
|
||
<p>This is only for demo purposes. <a href="#">I am a link</a></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
@use '../../compiled/tokens/scss/breakpoint'; | ||
@use '../../compiled/tokens/scss/color'; | ||
@use '../../compiled/tokens/scss/size'; | ||
@use '../../mixins/a11y'; | ||
@use '../../mixins/theme'; | ||
|
||
/// | ||
/// Subscribe component | ||
/// | ||
|
||
.c-subscribe { | ||
position: relative; | ||
} | ||
|
||
.c-subscribe__controls { | ||
display: grid; | ||
gap: 1em; | ||
margin: size.$rhythm-default 0; | ||
|
||
@media (min-width: breakpoint.$s) { | ||
grid-template-columns: 1fr 1fr; | ||
} | ||
} | ||
|
||
.c-subscribe__control { | ||
inline-size: 100%; | ||
} | ||
|
||
/// | ||
/// 1. Ensures the form background color matches the current theme | ||
/// | ||
|
||
.c-subscribe__form { | ||
background-color: var(--theme-color-background-base); // 1 | ||
block-size: 100%; | ||
inline-size: 100%; | ||
inset-block-start: 0; | ||
inset-inline-start: 0; | ||
position: absolute; | ||
|
||
/// | ||
/// 1. Allows for the visually hidden form to be keyboard accessible, will be | ||
/// visually hidden when elements within the form are not in focus. | ||
/// | ||
|
||
.c-subscribe__form-input-label, | ||
.c-subscribe:not(.activate-form) // 1 | ||
&:not(:target):not(:focus-within) { | ||
@include a11y.sr-only; | ||
} | ||
} | ||
|
||
.c-subscribe__form-input-group { | ||
margin: size.$rhythm-default 0; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.