-
Notifications
You must be signed in to change notification settings - Fork 3
Add Short Date Format and Unlinking to Author #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR adds two new features to the Author component. First, it adds the `unlink` property, which will prevent a link from being rendered even if one is provided as part of the Author object. This is useful for situations where removing the link property from the Author is a hassle. Second, it adds a `date_format` property, which can be set to `short` to use abbreviate date formatting.
🦋 Changeset detectedLatest commit: 3810da8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a design and template code perspective! Deferring approval to @cloudfour/dev once tests are passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a few comment suggestions inline
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Overview
This PR adds two new features to the Author component. First, it adds
the
unlink
property, which will prevent a link from being renderedeven if one is provided as part of the Author object. This is useful
for situations where removing the link property from the Author is
a hassle. Second, it adds a
date_format
property, which can be setto
short
to use abbreviate date formatting.Screenshots
Testing
short
date format displays correctlyunlink
property removes the author link when provided.