Skip to content

Conversation

spaceninja
Copy link
Member

Overview

This PR adds two new features to the Author component. First, it adds
the unlink property, which will prevent a link from being rendered
even if one is provided as part of the Author object. This is useful
for situations where removing the link property from the Author is
a hassle. Second, it adds a date_format property, which can be set
to short to use abbreviate date formatting.

Screenshots

Screen Shot 2022-04-14 at 10 38 25 AM

Testing

  1. On the preview deploy, ensure that the short date format displays correctly
  2. ensure the unlink property removes the author link when provided.
  3. ensure tests pass on this PR

This PR adds two new features to the Author component. First, it adds
the `unlink` property, which will prevent a link from being rendered
even if one is provided as part of the Author object. This is useful
for situations where removing the link property from the Author is
a hassle. Second, it adds a `date_format` property, which can be set
to `short` to use abbreviate date formatting.
@spaceninja spaceninja requested review from tylersticka and a team April 14, 2022 17:40
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

🦋 Changeset detected

Latest commit: 3810da8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit 3810da8
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/625863e52520950008209e05
😎 Deploy Preview https://deploy-preview-1727--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a design and template code perspective! Deferring approval to @cloudfour/dev once tests are passing.

Paul-Hebert
Paul-Hebert previously approved these changes Apr 14, 2022
Copy link
Contributor

@Paul-Hebert Paul-Hebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comment suggestions inline

Co-authored-by: Paul Hebert <paul@cloudfour.com>
spaceninja and others added 3 commits April 14, 2022 11:11
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Co-authored-by: Paul Hebert <paul@cloudfour.com>
Co-authored-by: Paul Hebert <paul@cloudfour.com>
@spaceninja spaceninja merged commit d8508b1 into v-next Apr 14, 2022
@spaceninja spaceninja deleted the feature/author-updates branch April 14, 2022 18:17
@github-actions github-actions bot mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants