Skip to content

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented Apr 18, 2022

Fixes #1695

You can test patterns that have auto-generated source code previews, for example:

Tyler did most of the figuring out/fixing, and I just added a fallback for storyContext.initialArgs.

I did not fix the syntax highlighting, I don't remember how that works and I don't know how to fix it

@calebeby calebeby self-assigned this Apr 18, 2022
@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2022

⚠️ No Changeset found

Latest commit: f885e24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit f885e24
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/625d8502627c8c0008704521
😎 Deploy Preview https://deploy-preview-1733--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@calebeby calebeby requested review from tylersticka and a team April 18, 2022 15:55
@calebeby calebeby marked this pull request as ready for review April 18, 2022 15:55
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @calebeby! Such a simple fix but I could not figure it out on my own.

@calebeby calebeby merged commit 20b126d into v-next Apr 18, 2022
@calebeby calebeby deleted the fix/broken-transform-source branch April 18, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component code doc example should show "embed"/"include" examples
2 participants