Skip to content

Remove Block Alignment Override Styles for Deck #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Remove Block Alignment Override Styles for Deck #1941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e1afd
Remove Block Alignment Override Styles for Deck
spaceninja Jul 13, 2022
72e0512
Create famous-mirrors-ring.md
spaceninja Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-mirrors-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudfour/patterns": patch
---

Remove block alignment override styles for Deck
19 changes: 0 additions & 19 deletions src/objects/deck/deck.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,3 @@
.o-deck--align-start {
align-items: start;
}

/**
* Block alignment adjustments
*
* 1. Set inline padding since we don't want the deck to touch the viewport
* edges even when it's full bleed.
* 2. Remove padding once `alignwide` is no longer full-bleed.
*/

.o-deck.alignfull,
.o-deck.alignwide {
@include spacing.fluid-padding-inline; // 1
}

.o-deck.alignwide {
@media (width >= breakpoint.$l) {
padding-inline: 0; // 2
}
}
18 changes: 0 additions & 18 deletions src/objects/deck/deck.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,24 +122,6 @@ The `o-deck--align-start` modifier can be used to top-align deck items. This mod
</Story>
</Canvas>

## Block Alignment

When used in WordPress, the `alignwide` and `alignfull` block alignment styles have been updated for use with the Deck.

<Canvas>
<Story
name="Block Alignment"
height="400px"
args={{
columns: 3,
columnsBreakpoint: '@m',
alignment: 'alignfull',
}}
>
{articlesStory.bind({})}
</Story>
</Canvas>

## Specifying Columns

While automatic columns are convenient, there are times when a specific column count is desired. For example, you may want to limit a design to three columns at larger breakpoints to align with adjacent elements.
Expand Down