Add size and muted props to Icon
#1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two new props to the Icon component: `muted`, which will render the icon slightly opaque, and `size` which will scale the icon to the requested icon size token.
🦋 Changeset detectedLatest commit: dd41aca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
gerardo-rodriguez
previously approved these changes
Jul 14, 2022
tylersticka
reviewed
Jul 14, 2022
There was a problem hiding this comment.
Works great, I agree with all of @gerardo-rodriguez's feedback (happy to defer approval to him)
Co-authored-by: Gerardo Rodriguez <gerardo@cloudfour.com>
gerardo-rodriguez
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds two new props to the Icon component:
muted, which willrender the icon slightly opaque, and
sizewhich will scale the iconto the requested icon size token.
Screenshots
Testing
Known Issues
The
mutedprop sets the opacity of the icon, which can reveal when the icon is made of overlapping parts, such as on the search icon. @tylersticka approved this.