Skip to content

Set a default border-width #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Set a default border-width #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c21b43
Set a default `border-width`
tylersticka Aug 3, 2022
9b5516a
Add changeset
tylersticka Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-turkeys-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': patch
---

Prevent border utility classes from accidentally setting `border-width` on all edges
4 changes: 4 additions & 0 deletions src/utilities/border/border.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,15 @@
* To improve the convenience of using these classes without having to specify
* a border style and color every time, we use the `:where` selector to set some
* reasonable defaults with no specificity depth.
*
* 1. Set a default `border-width` so legacy utility classes won't immediately
* display visible borders on all sides.
*/

:where([class^='u-border'], [class*=' u-border']) {
border-color: var(--theme-color-border-text-group);
border-style: solid;
border-width: 0; /* 1 */
}

/**
Expand Down