Remove focus-visible polyfill #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terns into chore/remove-focus-visible-polyfill * 'main' of https://github.com/cloudfour/cloudfour.com-patterns: Update dependency rollup to v2.78.1 Update dependency prismjs to v1.29.0 Update dependency sass to v1.54.5 Update dependency @types/lodash to v4.14.184 Update dependency @types/jest to v28.1.8 Update dependency @babel/core to v7.18.13
🦋 Changeset detectedLatest commit: 2c0ac51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gerardo-rodriguez
changed the title
spaceninja
approved these changes
Aug 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the
focus-visiblepolyfill in favor of the native:focus-visible.Screenshots
Testing
Review each before/after and confirm there are no visual differences when tabbing or clicking focusable elements.
Alert
Card
Checkbox
Footnote basic
Footnote Group basic
Footnote Group compact
Footnote Link basic
Heading permalink
Media Summary
Pagination
Sky Nav logo and "menu" toggle
Button
:focus-visiblepolyfill #1998