Enhance Calendar Date screen reader UX #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94167f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gerardo-rodriguez
changed the title
spaceninja
approved these changes
Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modifies the Calendar Date component in an attempt to create a better screen reader user experience.
Changes include:
Screenshots
No visual changes.
Testing
Before
"9"
"9, September 9, 2022"
"9"
"3-day event"
"9, September 9, 2022"
"3-day event, September 9, 2022"
After
"Single-day event"
"Single-day event"
"3-day event"
"3-day event"
Why is VoiceOver duplicating the date?
Because VoiceOver is silly. It's the only screen reader that exposes the
datetimeattribute. It probably shouldn't. The NVDA UX is much improved, while the VoiceOver UX is also better, even though it's slightly annoying that thedatetimevalue is read, causing the date to be announced twice. Nothing we can do about that, and in my opinion, this solution finds a nice middle-ground where both NVDA and VoiceOver UX are better and acceptable, even though the VoiceOver UX is not perfect.Previews