Skip to content

Conversation

tylersticka
Copy link
Member

Overview

  • Restores our icons from master to a new location.
  • Adds an SVGO config that may be used by any libraries using SVGO.
  • Updates config to support importing of SVG files as React components, which makes displaying them in Storybook easier.
  • Creates an "Icons" doc page that automatically displays any file in the icon folder.

Known issues

  • There isn't an icon CSS or Twig component yet. This is simply asset documentation.
  • The existing icons have been included "as-is." No modifications were made to them at this time.
  • It's unclear if assets/icons is the right place for these or not. We'll likely want to revisit as more assets are included, for example fonts (Variable font assets #469).
  • We may want to only apply the React transformation to SVGs in this particular context.
  • Whoa is that a Lanyrd icon?

Screenshot

Screenshot_2020-02-25 Icons - Page ⋅ Storybook


See #498

@tylersticka tylersticka requested a review from a team February 25, 2020 23:30
@tylersticka tylersticka merged commit c1f012a into v-next Feb 26, 2020
@tylersticka tylersticka deleted the feature/icons branch February 26, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants