-
Notifications
You must be signed in to change notification settings - Fork 1
Avoid hoisting #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hoisting #392
Conversation
🦋 Changeset detectedLatest commit: 7c18624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think we might as well change it for all of them. Not like we use them much anyways 😛 |
Also, you changed the typescript version of the rule but not the built in version of the rule. The built in version of the rule is currently enabled by eslint-plugin-standard, which we extend. You can set the rule in the main config block so it is enabled for .js too (the built-in rule is disabled for .ts files in favor of the TS version of the rule). |
Some of this code relied on hoisting to work and had to be deleted
Thanks @calebeby , this is ready for another review! |
Co-authored-by: Caleb Eby <calebeby@users.noreply.github.com>
Thanks @Paul-Hebert! |
This reverts commit a7d5860. It does not revert commits to generate-changeset, since those changes were small and fine, and reverting them conflicts with more recent changes.
After some internal discussion we decided to avoid relying on hoisting as it can be confusing.
Changes in
/fixtures/
files can largely be ignored while reviewing.