Skip to content

Conversation

Paul-Hebert
Copy link
Contributor

@Paul-Hebert Paul-Hebert commented Jun 22, 2022

After some internal discussion we decided to avoid relying on hoisting as it can be confusing.

Changes in /fixtures/ files can largely be ignored while reviewing.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: 7c18624

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/eslint-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@calebeby
Copy link
Member

calebeby commented Jun 22, 2022

I debated also changing the rule for classes and vars? But so far we haven't run into issues there so I left it alone.

I think we might as well change it for all of them. Not like we use them much anyways 😛

@calebeby
Copy link
Member

Also, you changed the typescript version of the rule but not the built in version of the rule. The built in version of the rule is currently enabled by eslint-plugin-standard, which we extend. You can set the rule in the main config block so it is enabled for .js too (the built-in rule is disabled for .ts files in favor of the TS version of the rule).

@Paul-Hebert Paul-Hebert changed the title Avoid function hoisting Avoid hoisting Jun 22, 2022
Paul Hebert added 2 commits June 22, 2022 16:11
Some of this code relied on hoisting to work and had to be deleted
@Paul-Hebert
Copy link
Contributor Author

Thanks @calebeby , this is ready for another review!

Co-authored-by: Caleb Eby <calebeby@users.noreply.github.com>
@Paul-Hebert Paul-Hebert merged commit a7d5860 into main Jun 23, 2022
@Paul-Hebert Paul-Hebert deleted the feat/avoid-function-hoisting branch June 23, 2022 15:51
@github-actions github-actions bot mentioned this pull request Jun 23, 2022
@calebeby
Copy link
Member

Thanks @Paul-Hebert!

Paul-Hebert pushed a commit that referenced this pull request Jul 1, 2022
This reverts commit a7d5860.

It does not revert commits to generate-changeset, since those changes were small and fine, and reverting them conflicts with more recent changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants