Update Homebrew #61
Merged
Update Homebrew #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release/scripts/_github_setup
Outdated
| # echo "skipping github setup since not on circle" | ||
| # exit | ||
| # fi | ||
| if [[ "${GH_ACTIONS:-}" != "true" ]]; then |
There was a problem hiding this comment.
I dont think we currently run the github setup stuff. Should we turn that on in the homebrew script? See here: https://github.com/cloudgraphdev/cli/blob/master/release/scripts/homebrew.js#L200
There was a problem hiding this comment.
No, I missed that the function calling this script is commented out. I'll remove this entirely and we can use the pipeline actions to do the config.
tyler-dunkel
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates configuration for Homebrew: