-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working #227
Merged
Merged
Working #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests added
* Keep backwards compatibility with previous cache options * Add tests to ensure glob matching with defined cache values * Updated README with instructions for new cache feature
Switched to a different option parser to keep things simple
Prevents uncaught exception: TypeError [ERR_INVALID_ARG_VALUE]: The argument 'path' must be a string or Uint8Array without null bytes.
- Maintenance: Add `.editorconfig` - Linting: Prefer const, no-var, fix indent, comment-out unused - npm: Add eslint devDep. and script - npm: Set engines to 10.11.0+ - npm: Add lock file
… non-null serverInfo
* commit '9c9389b30caa43c3e2c6f64d5adcad47780b2cde': Protect fs.stats calls from bad path arguments # Conflicts: # lib/node-static.js # test/integration/node-static-test.js
- npm: Change to 0.1.0 version
* commit '6617149b4c9f8c30251f5adceba0942c5ff2d097': allow access with local ip make sure ip/localhost/127.0.0.1 all work
* commit 'bd5d0444b2ef0d9709920f87e34f0a02c6411bdc': Small fix Test added: default extension does not interfere with folders Updated README Test validation of new option "defaultExtension" New fileServer option: defaultExtension Tests added Test bugfix Trying to finish the run # Conflicts: # .gitignore # lib/node-static.js # test/integration/node-static-test.js
- npm: Add to ignore file
- Refactoring: Reorder packge.json - npm: Bump to 0.1.1
This was referenced May 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates various other PRs and refactoring/improvements as per #224
Although this adds some noise in my scope change and reversion, I think it may nevertheless be useful to preserve rather than doing as one huge merge, so doing in this manner.
User-facing
engines
to 10.11.0+optimist
toneodoc
(@fidian)mime
andcolors
(@fidian)URL
constructor over deprecatedurl.parse
;should fix Open Redirect issue https://www.npmjs.com/advisories/1207
fs.stat
calls from bad path arguments; fixesDenial of Service issue https://www.npmjs.com/advisories/1208
(@brpvieira)
https://www.npmjs.com/advisories/1206 does not appear to be an issue
per testing (if it ever was); if you can provide a test case where it
fails, please report
bytes=0-0
Range header (@prajwalkman)spa
, allow dots after path (@gjuchault)serverInfo
to benull
(@martindale)--cache 0
(@matthew-andrews)defaultExtension
(@fmalk)static
reserved wordCHANGES.md
Dev-facing
prefer
startsWith
andincludes
colors
.editorconfig
node-static
vulnerabilitiesnull
and non-null
serverInfonyc
for coverage