Skip to content

Add the X,Y qualifiers to resize.limitFill by returning ResizeFillAction #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add the X,Y qualifiers to resize.limitFill by returning ResizeFillAction #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6374810
Add the X,Y qualifiers to resize.limitFill by returning ResizeFillAction
patrick-tolosa Jan 20, 2021
b89b9da
Add tests for resize.limitfill x and y qualifiers
patrick-tolosa Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions __TESTS__/unit/actions/Resize/LimitFillAction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,17 @@ describe('Tests for Transformation Action -- Resize.limitFill', () => {
'url');
expect(url).toContain('ar_1.2,c_lfill,g_auto,h_250,w_250');
});

it('Ensures it generates the right URL using xyGravity and x,y', () => {
const url = getImageWithResize(
limitFill()
.width(250)
.height(250)
.x(100)
.y(100)
.gravity(Gravity.xyCenter())
.aspectRatio(1.2),
'url');
expect(url).toContain('ar_1.2,c_lfill,g_xy_center,h_250,w_250,x_100,y_100');
});
});
6 changes: 3 additions & 3 deletions src/actions/resize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ function pad(width?: string|number, height?: string|number) :ResizePadAction<Com
* @memberOf Actions.Resize
* @param {number|string} width The required width of a transformed asset.
* @param {number|string} height The required height of a transformed asset.
* @return {LimitFillAction}
* @return {ResizeFillAction}
*/
function limitFill(width?: string|number, height?: string|number) :ResizeAdvancedAction {
return new ResizeAdvancedAction('lfill', width, height);
function limitFill(width?: string|number, height?: string|number) :ResizeFillAction {
return new ResizeFillAction('lfill', width, height);
}


Expand Down