Skip to content

Breaking - change the name of the named export of the entire SDK #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Breaking - change the name of the named export of the entire SDK #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6615d39
Breaking - change the name of the named export of the entire SDK
patrick-tolosa Feb 3, 2021
3e0b913
Add a missing test file
patrick-tolosa Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const bundleSizeTestCases:ITestCase[] = [
name: 'Import all of the SDK',
sizeLimitInKB: 110,
importsArray: [
importFromBase('CloudinarySDK')
importFromBase('CloudinaryBaseSDK')
]
}
];
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default [{
{
file: 'dist/bundles/umd/base.js',
format: 'umd',
name:'cloudinaryBase'
name:'CloudinaryBaseSDK'
}
],
plugins: [
Expand Down
7 changes: 3 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import {createCloudinaryV1URL} from "./backwards/createCloudinaryURL";
/**
* @namespace SDK
*/

const CloudinarySDK = {
const CloudinaryBaseSDK = {
Transformation,
ImageTransformation,
VideoTransformation,
Expand All @@ -37,6 +36,6 @@ export {
CloudinaryVideo,
CloudinaryFile,
createCloudinaryV1URL,
CloudinarySDK,
CloudinarySDK as default
CloudinaryBaseSDK,
CloudinaryBaseSDK as default
};