Skip to content

Add flag for ignore-mask-channels #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Add flag for ignore-mask-channels #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion __TESTS__/unit/actions/Flag.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ describe('Tests for Transformation Action -- Flag', () => {
.addFlag(Flag.keepIptc())
.addFlag(Flag.custom('myFlag'))
.addFlag(Flag.layerApply())
.addFlag(Flag.ignoreMaskChannels())



.setPublicID('sample')
.toURL();
Expand All @@ -57,7 +60,8 @@ describe('Tests for Transformation Action -- Flag', () => {
'fl_keep_attribution',
'fl_keep_iptc',
'fl_myFlag',
'fl_layer_apply'
'fl_layer_apply',
'fl_ignore_mask_channels'
].join('/');

expect(url).toBe(`https://res.cloudinary.com/demo/image/upload/${expectedToContain}/sample`);
Expand Down
14 changes: 12 additions & 2 deletions src/qualifiers/flag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,14 +484,24 @@ function waveform(): FlagQualifier {
return new FlagQualifier('waveform');
}

/**
* @summary qualifier
* @memberOf Qualifiers.Flag
* @description A qualifier that ensures that an alpha channel is not applied to a TIFF image if it is a mask channel.
* @return {Qualifiers.Flag.FlagQualifier}
*/
function ignoreMaskChannels(): FlagQualifier {
return new FlagQualifier('ignore_mask_channels');
}


const Flag = {
animated, anyFormat, animatedPng, animatedWebP,
clipEvenOdd, lossy, preserveTransparency, png8, png24, png32, progressive, rasterize,
sanitize, stripProfile, tiff8Lzw, attachment, forceIcc, forceStrip, getInfo, immutableCache,
keepAttribution, keepIptc, custom, streamingAttachment, hlsv3, keepDar, noStream, mono,
layerApply, relative, regionRelative, splice, truncateTS, waveform, ignoreInitialAspectRatio, clip,
tiled, noOverflow
tiled, noOverflow, ignoreMaskChannels
};

export {
Expand All @@ -500,7 +510,7 @@ export {
sanitize, stripProfile, tiff8Lzw, attachment, forceIcc, forceStrip, getInfo, immutableCache,
keepAttribution, keepIptc, custom, streamingAttachment, hlsv3, keepDar, noStream, mono,
layerApply, relative, regionRelative, splice, truncateTS, waveform, ignoreInitialAspectRatio, clip,
tiled, noOverflow
tiled, noOverflow, ignoreMaskChannels
};