Skip to content

add fadeIn fadeOut from/to Json #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2022
Merged

add fadeIn fadeOut from/to Json #511

merged 4 commits into from
Feb 6, 2022

Conversation

strausr
Copy link
Contributor

@strausr strausr commented Feb 3, 2022

Pull request for @cloudinary/url-gen

What does this PR solve?

  1. refactored fadeIn fadeOut actions to be standalone
  2. add fadeIn fadeOut from/to Json

const-cloudinary
const-cloudinary reviewed Feb 3, 2022
View reviewed changes
const-cloudinary
const-cloudinary approved these changes Feb 3, 2022
View reviewed changes
Copy link

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strausr strausr merged commit 202224d into master Feb 6, 2022
@mckomo-cl mckomo-cl deleted the feature/add-fade-in-and-out-from-to-json branch December 2, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-cloudinary const-cloudinary const-cloudinary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strausr @const-cloudinary