fix: update legacy splat operator

[RoseSecurity]

what

• Updated the syntax for accessing elements in a list from data.aws_iam_policy_document.kms_key_rds.*.json to data.aws_iam_policy_document.kms_key_rds[*].json.

why

• Enhance code consistency by addressing TFLint errors
• *. (splat operator) is an older syntax that returns a list but is not always well-typed. The newer explicit splat syntax is more consistent and predictable when accessing lists

references

• TFLint Rules

Summary by CodeRabbit

• Chores
  • Refined internal configuration handling to align with current Terraform standards.
  • The update enhances code maintainability without altering any user-visible functionality.

[coderabbitai]

Walkthrough

The Terraform module for kms_key_rds has been modified by updating the syntax for constructing the policy attribute. The change replaces the deprecated splat operator (.*) with the bracket notation ([*]) when accessing JSON representations of IAM policy documents. No functionality or other module attributes were impacted by this update.

Changes

File(s)	Change Summary
src/kms.tf	Replaced the splat operator (.*) with bracket notation ([*]) for accessing elements in the policy.

Possibly related PRs

• fix: Replace deprecated splat expression with [*] for Terraform 1.5.6… #19: Involves a similar update by replacing the deprecated splat operator with the bracket notation in Terraform configurations.

Poem

I'm a rabbit with a flair for code,
Hopping through files on my winding road.
Out with splats, in with brackets so neat,
Carrot crunch echoes with every beat.
A joyful hop in Terraform tone,
Celebrating changes in my cozy zone.
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d573e65 and f05b911.

📒 Files selected for processing (1)

• src/kms.tf (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Mergify Merge Protections
• GitHub Check: Mergify Merge Protections
• GitHub Check: Summary

🔇 Additional comments (1)

src/kms.tf (1)

8-8: Updated Terraform syntax for policy attribute.
The change from the legacy splat operator (.*) to the modern bracket notation ([*]) for accessing the JSON attribute is correctly applied. This update enhances type safety and aligns the code with current Terraform best practices. Please verify that joining the JSON fragments with an empty delimiter produces the expected valid policy (especially in cases where multiple documents might exist or when the list is empty).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mergify]

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require terratest

Wonderful, this rule succeeded.

This rule require terratest status

• check-success = test/terratest

[RoseSecurity]

/terratest

[GabisCampana]

@goruha

[github-actions]

These changes were released in v1.537.0.