-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: expose security group ID for Aurora Postgres cluster #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add security_group_id output to expose the security group ID from the underlying RDS cluster module - This enables proper configuration of inbound and outbound traffic rules for ECS services
WalkthroughAdds a Terraform output named security_group_id in src/outputs.tf, exposing module.aurora_postgres_cluster.security_group_id with a description. Placed after existing outputs; no other files or logic modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/outputs.tf (1)
73-73
: Consistency nit: end description with a period.Matches nearby
allowed_security_groups
description style.Apply this minimal change:
- description = "The security group ID of the Aurora Postgres cluster" + description = "The security group ID of the Aurora Postgres cluster."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/outputs.tf
(1 hunks)
🔇 Additional comments (1)
src/outputs.tf (1)
71-74
: Confirm remote module exportssecurity_group_id
: The modulecloudposse/rds-cluster/aws
v2.1.1 (referenced in src/cluster-regional.tf) must expose an output namedsecurity_group_id
, or the plan will fail. Also verify this output is populated both when you supply an existing SG and when the module creates one.
/terratest |
These changes were released in v1.539.0. |
what
why
references
.
Summary by CodeRabbit