Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow (ignored) standard options for terraform clean #4

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Allow (ignored) standard options for terraform clean #4

merged 1 commit into from
Oct 30, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 29, 2020

what

  • Allow terraform clean to take --stage and --environment options, even though they will be ignored

why

  • Some scripts and tools provide those options for all Terraform commands that operate on a project, so it is convenient to allow them to provide the options to terraform clean even if they will be ignored, rather than raise an error about unknown options

@Nuru Nuru added the patch A minor, backward compatible change label Oct 29, 2020
@Nuru Nuru requested a review from a team as a code owner October 29, 2020 23:43
@Nuru Nuru merged commit c261f52 into master Oct 30, 2020
@Nuru Nuru deleted the opts branch October 30, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh