Update modules #65
Merged
Update modules #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Oct 29, 2021
| } | ||
|
|
||
| if len(c.Config.Stacks.NamePattern) < 1 { | ||
| return nil, errors.New("stack name pattern must be provided in 'stacks.name_pattern' config or 'ATMOS_STACKS_NAME_PATTERN' ENV variable") |
There was a problem hiding this comment.
line 50 is the same as this line
It would be nice to have an errors.go module that housed each of these error messages so could call upon them using errors.stack_pattern_mismatch or similar to keep it DRY
There was a problem hiding this comment.
yes, common modules would be nice
There was a problem hiding this comment.
those are the same since the functions are used at diff times, and they both need NamePattern so they check if it exists
nitrocode
reviewed
Oct 29, 2021
| } | ||
| } else if part == "{stage}" { | ||
| if len(stage) == 0 { | ||
| return nil, errors.New(fmt.Sprintf("stack name pattern '%s' includes '{stage}', but stage is not provided", c.Config.Stacks.NamePattern)) |
osterman
approved these changes
Oct 29, 2021
nitrocode
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
atmoscode but was modified in Update the provider to use latest stacks and components features. Improve examples and tests terraform-provider-utils#62 - syncatmosandutilsprovider