Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #14

Merged
merged 1 commit into from Jan 8, 2018
Merged

Update documentation #14

merged 1 commit into from Jan 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 26, 2017

what

  • Update documentation with instructions for SLACK_ENABLED

why

  • By default SLACK_ENABLED is set to 'false' which can be disappointing when a SLACK_WEBHOOK is specified but no notification is sent.
  • It could be useful to specify the enabled flag for users which wants to enable Slack notifications.

By default SLACK_ENABLED is set to 'false' which can be disappointing when a SLACK_WEBHOOK is specified but no notification is send. So it could be useful to specify the enabled flag for users which wants to enable Slack notifications.
@osterman osterman self-assigned this Dec 27, 2017
@osterman
Copy link
Member

@aknysh can you look into why the travis build is failing? It's unrelated to changes in this PR.

@osterman osterman merged commit 06ca51a into cloudposse:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants