Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode caching fix #934

Merged
merged 2 commits into from
May 2, 2024
Merged

Dark mode caching fix #934

merged 2 commits into from
May 2, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 2, 2024

what

  • Fix caching of terminal escape codes
  • Update update-terminal-mode command to allow forcing a mode
  • rename internal update_terraform_prompt to _update_terraform_prompt

why

  • Substantial performance improvement on every command line prompt
  • Auto-detection is likely to be unavailable or wrong on some terminals
  • Keep internal functions from showing up in command line completions

@Nuru Nuru added the bugfix Change that restores intended behavior label May 2, 2024
@Nuru Nuru requested a review from a team as a code owner May 2, 2024 05:40
@github-actions github-actions bot added the shell label May 2, 2024
@Nuru Nuru merged commit 95a107d into master May 2, 2024
6 checks passed
@Nuru Nuru deleted the dark-mode-fix branch May 2, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant