-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudTrail Advanced Event Selector #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @X-Guardian for the contribution, once the terratest past we should be good to go
/terratest |
the test failed, can you check? And take a look at this please: it might be better to move it to a single object. |
Looks like the test framework is using a very old version of Terraform, so I have bumped the Terraform version in the example. I have only added a single object... |
/terratest |
The successful running of the tests is blocked by cloudposse/terraform-aws-cloudtrail-s3-bucket#90 |
/terratest |
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
/terratest |
what
Add support for the CloudTrail advanced event selector
Also bumps the example
cloudtrail_s3_bucket module
and Terraform versions to fix test errors.By @Nuru:
exclude_management_event_sources
. Supersedes and closes add input exclude_management_event_sources closes #54 #60. Closes Unable to use exclude_management_event_sources in event_selector #54..editorconfg
.tflint
complaints.references