Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spacelift worker pool enhancements #1029

Merged

Conversation

RoseSecurity
Copy link
Member

@RoseSecurity RoseSecurity commented May 6, 2024

what

  • Adds instance_lifetime variable
  • Adds logic for launch_template_version
  • Makes AMI filter for architecture extensible

why

  • Adds instance_lifetime to enhance security of worker by terminating and replacing long-lived instances

Note

The addition of this variable is purely for security purposes and can be removed if contributors deem it unnecessary

  • A refresh will not start when version = "$Latest" is configured in the launch_template block. To trigger the instance refresh when a launch template is changed, configure version to use the latest_version attribute of the aws_launch_template resource.

references

@RoseSecurity RoseSecurity requested review from a team as code owners May 6, 2024 03:08
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoseSecurity thank you, the PR looks good, please see comment about the legacy splat expression .*.

@RoseSecurity
Copy link
Member Author

@RoseSecurity thank you, the PR looks good, please see comment about the legacy splat expression .*.

@aknysh Just reverted the splat operator for the files. Thank you!

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RoseSecurity

@aknysh aknysh merged commit ee59fd8 into cloudposse:main May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants