-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spacelift worker pool enhancements #1029
feat: Spacelift worker pool enhancements #1029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoseSecurity thank you, the PR looks good, please see comment about the legacy splat expression .*.
@aknysh Just reverted the splat operator for the files. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @RoseSecurity
what
instance_lifetime
variablelaunch_template_version
why
instance_lifetime
to enhance security of worker by terminating and replacing long-lived instancesNote
The addition of this variable is purely for security purposes and can be removed if contributors deem it unnecessary
version = "$Latest"
is configured in thelaunch_template
block. To trigger the instance refresh when a launch template is changed, configureversion
to use thelatest_version
attribute of theaws_launch_template
resource.references