Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for karpenter 0.34.0 or newer #983

Closed
wants to merge 1 commit into from
Closed

feat: add support for karpenter 0.34.0 or newer #983

wants to merge 1 commit into from

Conversation

sgtoj
Copy link
Contributor

@sgtoj sgtoj commented Feb 20, 2024 •
edited
Loading

what

  • update eks/karpetner and eks/karpenter-provisioner to support Karpenter v0.34.0
  • update controller's iam policy to be nearly identical to the policy included with Karpenter's CloudFormation template
    • only changed the arn and alike for resources to match cloudposse's deployed resources
  • allow deployment to existing k8s namespaces
  • reduce code smell

why

  • Karpetner v0.34.0 included multiple breaking changes
    • moved chart values for settings.aws to settings
    • replaced Provisioner with NodePool resource
    • replaced AWSNodeTemplate with EC2NodeClass

references

@sgtoj sgtoj requested review from a team as code owners February 20, 2024 18:22
Nuru
Nuru requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until I have a chance to thoroughly review this in the next week or two.

@Nuru Nuru added the do not merge Do not merge this PR, doing so would cause problems label Feb 27, 2024
@Nuru Nuru added the wontfix This will not be worked on label Jun 2, 2024
@Nuru
Copy link
Contributor

Nuru commented Jun 2, 2024 •
edited
Loading

Superseded by

@Nuru Nuru closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

Assignees
No one assigned
Labels
do not merge Do not merge this PR, doing so would cause problems wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eks/karpenter and eks/karpenter-provisioner does not support latest Karpenter
2 participants
@sgtoj @Nuru