Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding pipeline type to module and provided a working example #129

Closed
wants to merge 8 commits into from
Closed

feat: Adding pipeline type to module and provided a working example #129

wants to merge 8 commits into from

Conversation

Roondel
Copy link
Contributor

@Roondel Roondel commented Apr 2, 2024

what

Adding pipeline_type to the module to set whether V1 or the newer V2 version is deployed.

why

This feature will allow for both github and bitbucket pipelines to de deployed as version 2.

references

https://docs.aws.amazon.com/codepipeline/latest/userguide/pipeline-types.html

@Roondel Roondel requested review from a team as code owners April 2, 2024 14:17
@mergify mergify bot added the triage Needs triage label Apr 2, 2024
variables.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
examples/complete/variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@joe-niland
Copy link
Member

Hi @Roondel
I spoke to the team. Would you be able to add support for the other v2 features (trigger, variable, execution modes) and then we'll see what the best course of action is? Allowing v2 to be set doesn't have much effect otherwise.

I can help with changes/testing, as we use CodePipeline with our clients.

@Roondel Roondel closed this by deleting the head repository Jun 5, 2024
@mergify mergify bot removed the triage Needs triage label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants