Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #29

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #29

merged 4 commits into from
Jul 3, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jul 3, 2019

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules

related

@aknysh aknysh self-assigned this Jul 3, 2019
@aknysh aknysh requested a review from osterman July 3, 2019 16:32
@aknysh aknysh merged commit cb66688 into master Jul 3, 2019
@aknysh aknysh deleted the terraform-0.12 branch July 3, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terraform 0.12 support Error deleting S3 Bucket {logs-bucket} : BucketNotEmpty Add Example Usage
2 participants
@aknysh @osterman