feat: Add nil pointer faking #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Jul 14, 2022
faker.go
Outdated
| // FakeDataWithNilPointerGenerator returns a generator that can be used to create successive fakes with | ||
| // a single pointer set to nil. This can be used to iterate through fakes with all possible pointer fields | ||
| // set to nil, to catch nil pointer-dereference errors. | ||
| func FakeDataWithNilPointerGenerator() *generator { |
There was a problem hiding this comment.
Exported method returning an unexported struct looks weird
There was a problem hiding this comment.
Good point. It's technically valid but can prevent manipulation by packages using the function. We actually only need the Next() method, so I've changed it to return a public interface that exposes only that method instead.
yevgenypats
approved these changes
Jul 14, 2022
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
FakeDataWithNilPointerGenerator, a function that returns a generator. On successive calls, the generator returns a filled out interface with exactly one pointer field set to nil. This can be used in tests to detect nil pointer dereference errors.