Skip to content

Conversation

jperals
Copy link
Member

@jperals jperals commented Sep 24, 2025

Issue #, if available:

Description of changes:

In order to calculate an element's content size from the box size, subtract not only the padding but also the border thickness, if any.

  • Tested manually by adding logpoints in the container-queries dev page in the components package —for boxes with border, the measurement in the initial render was wrong by the amount of the border thickness, which gets fixed with this change
  • Tested in my pipeline
  • Dry run: 7532974560

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (a5de60f) to head (fbeb392).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   98.77%   98.78%           
=======================================
  Files          36       36           
  Lines         900      904    +4     
  Branches      239      255   +16     
=======================================
+ Hits          889      893    +4     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals marked this pull request as ready for review September 29, 2025 10:19
@jperals jperals requested a review from a team as a code owner September 29, 2025 10:19
@jperals jperals requested review from ernst-dev and removed request for a team September 29, 2025 10:19
@jperals jperals enabled auto-merge September 29, 2025 12:14
@jperals jperals added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2025
@jperals jperals added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 90b095e Sep 30, 2025
148 of 151 checks passed
@jperals jperals deleted the fix/resize-observer-border branch September 30, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants