feat: AI drawer header actions #3824

georgylobko · 2025-09-02T08:44:06Z

Description

This PR adds a new API for declaring header actions in global panels registered through the plugin API. The goal is to make it easier to add actions to panel headers. Currently, teams have to create custom buttons
with absolute positioning, which causes accessibility issues. This PR fixes that by using the existing ButtonGroup component instead.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov · 2025-09-02T09:01:19Z

Codecov Report

❌ Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.13%. Comparing base (ce7b93a) to head (1bc402d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/app-layout/runtime-drawer/index.tsx	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3824      +/-   ##
==========================================
- Coverage   97.14%   97.13%   -0.02%     
==========================================
  Files         844      844              
  Lines       24515    24549      +34     
  Branches     8645     8658      +13     
==========================================
+ Hits        23815    23845      +30     
- Misses        693      697       +4     
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

just-boris · 2025-09-02T12:13:17Z

src/app-layout/__tests__/runtime-drawers.test.tsx

        expect(onToggle).toHaveBeenCalledWith({ isOpen: false, initiatedByUserAction: true });
      });
+
+      (type === 'global-ai' ? test : test.skip)(


I started a new file for this new API: https://github.com/cloudscape-design/components/blob/main/src/app-layout/__tests__/runtime-drawers-widgetized.test.tsx

It is better to add new exclusive features there

this test is no longer specific for the ai drawer - it now applies for to both global and global-ai

georgylobko · 2025-09-04T15:56:25Z

src/app-layout/visual-refresh-toolbar/drawer/global-drawer.tsx

+                      if (!root) {
+                        return;
+                      }
+                      refs.close = { current: root.querySelector('[data-itemid="close"]') as unknown as Focusable };


I'm open to any suggestion to make it better

Ok to merge as a temporary solution.

But let's ask in the P&C channel for help. Most likely we should expose a new package-private API to assign refs on button group items

just-boris

All comments ⛳ are merge blocking, the rest are follow ups

just-boris · 2025-09-04T16:16:33Z

pages/app-layout/utils/external-global-left-panel-widget.tsx

+      id: 'add',
+      iconName: 'add-plus',
+      text: 'Add',
+      popoverFeedback: <StatusIndicator type="success">Message copied</StatusIndicator>,


⛳ This is not going to work in the real world when the React instance used in the widget and version used in app layout are different

Perhaps we should omit all slot properties from this API (or print a warning they are not supported in this mode)

Printed a warning for unsupported props

We need to remove these instances, because having them with a warning may confuse if this use-case is supported or not (it is not supported)

just-boris · 2025-09-04T16:38:59Z

src/app-layout/visual-refresh-toolbar/drawer/global-drawer.tsx

  const animationDisabled =
    (activeGlobalDrawer?.defaultActive && !drawersOpenQueue.includes(activeGlobalDrawer.id)) ||
    (wasExpanded && !isExpanded);
+  let drawerActions: ReadonlyArray<ButtonGroupProps.InternalItemOrGroup> = [


⛳ Is it the same code as above?

This needs to be deduplicated

no, it might look similar, but it's not the same. global drawer and left global drawer have slightly different set of props

just-boris · 2025-09-04T16:40:31Z

src/app-layout/visual-refresh-toolbar/drawer/global-drawer.tsx

+                      if (!root) {
+                        return;
+                      }
+                      refs.close = { current: root.querySelector('[data-itemid="close"]') as unknown as Focusable };


Ok to merge as a temporary solution.

But let's ask in the P&C channel for help. Most likely we should expose a new package-private API to assign refs on button group items

just-boris · 2025-09-04T16:42:09Z

src/button-group/interfaces.ts

    popoverFeedback?: React.ReactNode;
  }

+  export interface InternalIconButton extends IconButton {


⛳ This lives inside ButtonGroupProps namespace which is public.

You need to move all private additions outside this namespace to avoid exporting to public

…mespace

…ions in runtime api

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 9345d9e to a2d9ca3 Compare September 2, 2025 08:48

georgylobko deployed to dev-pages September 2, 2025 09:01 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 96be15b to 638e75a Compare September 2, 2025 10:18

georgylobko deployed to dev-pages September 2, 2025 10:27 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 8e1780c to 5e46e42 Compare September 2, 2025 11:25

georgylobko deployed to dev-pages September 2, 2025 11:34 — with GitHub Actions View deployment

just-boris reviewed Sep 2, 2025

View reviewed changes

georgylobko deployed to dev-pages September 2, 2025 13:58 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 00e0963 to 97b03bf Compare September 3, 2025 08:21

georgylobko deployed to dev-pages September 3, 2025 08:30 — with GitHub Actions View deployment

georgylobko deployed to dev-pages September 3, 2025 16:10 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch from fc85522 to 4a7b1ba Compare September 4, 2025 09:21

georgylobko deployed to dev-pages September 4, 2025 09:30 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 4a7b1ba to c2175eb Compare September 4, 2025 09:51

georgylobko deployed to dev-pages September 4, 2025 10:00 — with GitHub Actions View deployment

georgylobko force-pushed the feat/ai-drawer-header-actions branch 2 times, most recently from 591b7b2 to 77cc90b Compare September 4, 2025 14:48

georgylobko deployed to dev-pages September 4, 2025 14:57 — with GitHub Actions View deployment

georgylobko deployed to dev-pages September 4, 2025 15:39 — with GitHub Actions View deployment

georgylobko marked this pull request as ready for review September 4, 2025 15:54

georgylobko requested a review from a team as a code owner September 4, 2025 15:54

georgylobko requested review from ernst-dev and removed request for a team September 4, 2025 15:54

georgylobko commented Sep 4, 2025

View reviewed changes

just-boris reviewed Sep 4, 2025

View reviewed changes

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 7efd67a to 8e36467 Compare September 5, 2025 09:06

georgylobko deployed to dev-pages September 5, 2025 09:15 — with GitHub Actions View deployment

georgylobko deployed to dev-pages September 5, 2025 09:29 — with GitHub Actions View deployment

georgylobko deployed to dev-pages September 5, 2025 12:30 — with GitHub Actions View deployment

georgylobko requested a review from just-boris September 5, 2025 12:43

just-boris approved these changes Sep 5, 2025

View reviewed changes

georgylobko deployed to dev-pages September 5, 2025 15:11 — with GitHub Actions View deployment

georgylobko added 12 commits September 9, 2025 15:31

feat: AI drawer header actions

7d200c1

fix: U tests

3f7c8bb

chore: Increase limit size

f7af00b

chore: U test

79b3d05

chore: Make button group send analyticsAction

e547dbb

chore: Implement headerActions api for global drawers

79f46c2

fix: Global drawer headerActions

3fd3047

chore: Increase size limit

6c0598a

fix: Drawer's expanded button selector for an integ test

1e43c48

chore: Bring InternalIconButton out of the public ButtonGroupProps na…

31ce8f7

…mespace

chore: Throw a warning if unsupported props are used inside headerAct…

cb65c02

…ions in runtime api

chore: Remove popoverFeedback from headerActions

1bc402d

georgylobko force-pushed the feat/ai-drawer-header-actions branch from 177de3f to 1bc402d Compare September 9, 2025 13:32

georgylobko deployed to dev-pages September 9, 2025 14:25 — with GitHub Actions View deployment

georgylobko added this pull request to the merge queue Sep 9, 2025

Merged via the queue into main with commit 979d270 Sep 9, 2025
41 of 42 checks passed

georgylobko deleted the feat/ai-drawer-header-actions branch September 9, 2025 14:46

at-susie pushed a commit that referenced this pull request Sep 17, 2025

feat: AI drawer header actions (#3824)

dc6fd45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: AI drawer header actions #3824

feat: AI drawer header actions #3824

Uh oh!

georgylobko commented Sep 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

just-boris Sep 2, 2025

Uh oh!

georgylobko Sep 4, 2025

Uh oh!

georgylobko Sep 4, 2025

Uh oh!

just-boris Sep 4, 2025

Uh oh!

just-boris left a comment

Uh oh!

just-boris Sep 4, 2025

Uh oh!

georgylobko Sep 5, 2025

Uh oh!

just-boris Sep 5, 2025

Uh oh!

just-boris Sep 4, 2025

Uh oh!

georgylobko Sep 5, 2025

Uh oh!

just-boris Sep 4, 2025

Uh oh!

just-boris Sep 4, 2025

Uh oh!

georgylobko Sep 5, 2025

Uh oh!

Uh oh!

Uh oh!

feat: AI drawer header actions #3824

feat: AI drawer header actions #3824

Uh oh!

Conversation

georgylobko commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How has this been tested?

Correctness

Security

Testing

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

just-boris left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

georgylobko commented Sep 2, 2025 •

edited

Loading

codecov bot commented Sep 2, 2025 •

edited

Loading